5
11
Fork
You've already forked tomato
1

Fixing 3 event bugs #84

Merged
edwardloveall merged 4 commits from el-event-bugs into main 2026年01月29日 15:49:16 +01:00

This fixes three bugs (and a tiny cleanup) relating to exdates and updating into the future. Check out each commit to see the details.

  • Ensure future single events get updated attributes
  • Prevent past exdates from carrying over to split events
  • Don't update past exdates
This fixes three bugs (and a tiny cleanup) relating to exdates and updating into the future. Check out each commit to see the details. * Ensure future single events get updated attributes * Prevent past exdates from carrying over to split events * Don't update past exdates
@ -0,0 +1,39 @@
class RemoveOldExdates < ActiveRecord::Migration[8.0]
def up
execute <<~SQL
First-time contributor
Copy link

I'm continually amazed at your prowess with SQL. This is awesome. 😄

I'm continually amazed at your prowess with SQL. This is awesome. 😄
Author
Owner
Copy link

Last job was heavy SQL and had really strong SQL writers so I got really good. I also find postgres really fun. I'd love to share that so please let me know if you're every struggling to do some complex SQL.

Last job was heavy SQL and had really strong SQL writers so I got really good. I also find postgres really fun. I'd love to share that so please let me know if you're every struggling to do some complex SQL.
@ -0,0 +28,4 @@
from updated_exdate_events
-- match the CTE to the table
where events.id = updated_exdate_events.id
-- dopn't update rows that have no differences
First-time contributor
Copy link

typo nitpick: dopn't -> don't

typo nitpick: `dopn't` -> `don't`
edwardloveall force-pushed el-event-bugs from c46ffb39ee
Some checks failed
Setup Successful
Jest Successful
RSpec Failed
Static Analysis Successful
to 5d18eb565a
Some checks failed
Setup Successful
Jest Successful
RSpec Failed
Static Analysis Successful
2026年01月29日 15:33:47 +01:00 Compare
edwardloveall changed target branch from el-snapshot-prune to main 2026年01月29日 15:34:49 +01:00
edwardloveall force-pushed el-event-bugs from 5d18eb565a
Some checks failed
Setup Successful
Jest Successful
RSpec Failed
Static Analysis Successful
to ab4d9e15dc
All checks were successful
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Successful
2026年01月29日 15:36:12 +01:00 Compare
Author
Owner
Copy link

Test failure is flaky. It's an the admins inviting admins test and for whatever reason, it fails to find/fill out the email address. My plan to fix this is convert the form to not user material ui, which will remove some of the weird js interactions the page has in hopes that it will make it more stable.

Test failure is flaky. It's an the [admins inviting admins](https://codeberg.org/rootable/tomato/src/branch/main/spec/system/administration/users_spec.rb#L4) test and for whatever reason, it fails to find/fill out the email address. My plan to fix this is convert the form to not user material ui, which will remove some of the weird js interactions the page has in hopes that it will make it more stable.
edwardloveall deleted branch el-event-bugs 2026年01月29日 15:49:17 +01:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rootable/tomato!84
Reference in a new issue
rootable/tomato
No description provided.
Delete branch "el-event-bugs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?