5
11
Fork
You've already forked tomato
1

Move copy task logs to drop off side #76

Merged
edwardloveall merged 1 commit from el-copy-task-edits into main 2026年01月26日 16:14:12 +01:00

Volunteers were not finding the button on the drop off side, so we're going to
try it over here.

Also, the backend implementation was mirroring the UI too much. We were passing
in a task to copy to along with the event. But we're also checking that the
event has exactly two tasks—a pickup and a drop off—and the copying only goes
one way so the extra param was not needed.

This refactors the TaskLogReplacer so that all you need to pass is the event in
question.

Also, because the button is not "push" instead of "pull" it's difficult to know
if anything actually happened. The button now changes from "Copy logs to drop
off task" to "Copied" when clicked and changes back if the page is reloaded or
someone creates a new task log.

Volunteers were not finding the button on the drop off side, so we're going to try it over here. Also, the backend implementation was mirroring the UI too much. We were passing in a task to copy _to_ along with the event. But we're also checking that the event has exactly two tasks—a pickup and a drop off—and the copying only goes one way so the extra param was not needed. This refactors the TaskLogReplacer so that all you need to pass is the event in question. Also, because the button is not "push" instead of "pull" it's difficult to know if anything actually happened. The button now changes from "Copy logs to drop off task" to "Copied" when clicked and changes back if the page is reloaded or someone creates a new task log.
edwardloveall force-pushed el-copy-task-edits from aeb9595aff
Some checks failed
Setup Successful
Jest Successful
RSpec Failed
Static Analysis Successful
to 73c81cd1e4
Some checks failed
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Failed
2026年01月22日 22:41:29 +01:00
Compare
thetizzo left a comment
Copy link

This looks good. I like just passing the event and finding the task logs through that.

This looks good. I like just passing the event and finding the task logs through that.
edwardloveall changed target branch from el-site-form-refactor to main 2026年01月26日 16:12:53 +01:00
edwardloveall deleted branch el-copy-task-edits 2026年01月26日 16:14:13 +01:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rootable/tomato!76
Reference in a new issue
rootable/tomato
No description provided.
Delete branch "el-copy-task-edits"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?