5
11
Fork
You've already forked tomato
1

Ensure that replace task logs button shows up after entering log #72

Merged
edwardloveall merged 1 commit from el-fix-replace-log into main 2026年01月15日 15:10:50 +01:00

I had a useEffect that would reevaluate if the logs changed. It enabled
or disabled the replace button. However, the task logs are a nested
array (index is task id, value is array of tasks logs). For some
reason, when the inner array of logs is updated, it doesn't count as
new state.

So I extracted a more specific thing out of the useEffect (the pickup
logs; a single array) to watch for instead.

I had a useEffect that would reevaluate if the logs changed. It enabled or disabled the replace button. However, the task logs are a nested array (index is task id, value is array of tasks logs). For some reason, when the inner array of logs is updated, it doesn't count as new state. So I extracted a more specific thing out of the useEffect (the pickup logs; a single array) to watch for instead.
edwardloveall force-pushed el-fix-replace-log from 7d23b497f2
Some checks failed
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Failed
to ad4d078824
Some checks failed
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Failed
2026年01月14日 16:09:33 +01:00
Compare
thetizzo left a comment
Copy link

Looks good!

Looks good!
edwardloveall deleted branch el-fix-replace-log 2026年01月15日 15:10:51 +01:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rootable/tomato!72
Reference in a new issue
rootable/tomato
No description provided.
Delete branch "el-fix-replace-log"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?