5
11
Fork
You've already forked tomato
1

missing_task_log? is only true if there are zero tasks with logs #70

Merged
edwardloveall merged 1 commit from el-log-reminder-cleanup into main 2026年01月08日 21:06:20 +01:00

Previously, we considered events to have "missing logs" if any of their tasks
did not have a task log. But now we'd like to switch so that we only consider
missing logs if there are no logs attached to the events tasks.

  • Event
    • task 1
      • task log
    • task 2

This event used to return true for missing_task_log? because task 2 did not
have log. But now it will return false because it has at least one log (on
task 1).

Previously, we considered events to have "missing logs" if any of their tasks did not have a task log. But now we'd like to switch so that we only consider missing logs if there are no logs attached to the events tasks. - Event - task 1 - task log - task 2 This event used to return `true` for `missing_task_log?` because task 2 did not have log. But now it will return `false` because it has at least one log (on task 1).
edwardloveall force-pushed el-log-reminder-cleanup from 768d246b7a
Some checks failed
Setup Successful
Jest Failed
Static Analysis Failed
RSpec Failed
to 097803668c
All checks were successful
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Successful
2026年01月07日 22:28:10 +01:00 Compare
jsilasbailey left a comment
Copy link

👍

👍
@ -302,0 +304,4 @@
it "returns false if there are no tasks" do
event = create(:event, tasks: [])
expect(event.missing_task_log?).to eq(false)
First-time contributor
Copy link

I noticed that the test below is using the rspec predicate matchers and this one is calling the method explicitly. I prefer not to use the predicate matchers in my own tests, but you might consider modifying those tests below as well to be consistent if there aren't too many.

I noticed that the test below is using the rspec predicate matchers and this one is calling the method explicitly. I prefer not to use the predicate matchers in my own tests, but you might consider modifying those tests below as well to be consistent if there aren't too many.
Author
Owner
Copy link

Good catch. I removed the predicate style. I kinda flip back and forth on using them, but I totally get why you would not. I'm the same with with unless and let (too clever; avoid at all costs).

Good catch. I removed the predicate style. I kinda flip back and forth on using them, but I totally get why you would not. I'm the same with with `unless` and `let` (too clever; avoid at all costs).
@ -302,0 +308,4 @@
end
# the same task can belong to multiple events, but task logs belong to a
# speicfic event. this means, for example, that we can't just count a task's
First-time contributor
Copy link

spl: "specific"

spl: "specific"
@ -302,0 +311,4 @@
# speicfic event. this means, for example, that we can't just count a task's
# task logs to know if any are missing for a specific event. we must only
# check the task logs that belong to the event in question
it "only task logs that belong to the event" do
First-time contributor
Copy link

"only checks task logs ..." ?

"only checks task logs ..." ?
edwardloveall force-pushed el-log-reminder-cleanup from 097803668c
All checks were successful
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Successful
to 2ad781fabc
Some checks failed
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Failed
2026年01月08日 17:31:57 +01:00 Compare
edwardloveall force-pushed el-log-reminder-cleanup from 2ad781fabc
Some checks failed
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Failed
to 365f3e4ba2
All checks were successful
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Successful
2026年01月08日 20:42:15 +01:00 Compare
Author
Owner
Copy link

Failing tests are known flakes with timeouts and capybara being (I think) too fast for some react/material JS stuff.

Failing tests are known flakes with timeouts and capybara being (I think) too fast for some react/material JS stuff.
edwardloveall deleted branch el-log-reminder-cleanup 2026年01月08日 21:06:20 +01:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rootable/tomato!70
Reference in a new issue
rootable/tomato
No description provided.
Delete branch "el-log-reminder-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?