5
11
Fork
You've already forked tomato
1

Upgrade to rails 8 #58

Merged
edwardloveall merged 7 commits from el-rails-8 into main 2025年12月09日 22:07:55 +01:00

Mostly following the defaults, here. I also fixed a bug I introduced in a previous commit. See d95c7486fd for details.

Mostly following the defaults, here. I also fixed a bug I introduced in a previous commit. See d95c7486fdf3190b4a5ade0248ffc33c6cc93b7d for details.
Rails routes in rails 8 are lazily loaded, but devise needs the routes
loaded to setup it's mappings:
https://alvincrespo.hashnode.dev/rails-8s-lazy-route-loading-devise
If the routes are not loaded, you get errors like:
Could not find a valid mapping for #<User...
I actually broke this in 9be0738 when converting to UJS. I thought this
form did not need the `method: :post` but I was wrong. Passing an
existing object to `form_for` uses the `PATCH` HTTP method, but we want
`POST` here.
Ignore environment files in standardrb
Some checks failed
Setup Successful
Jest Successful
RSpec Failed
Static Analysis Failed
4fa36615cc
These are _mostly_ auto generated by rails upgrades. Getting rails
maintainers and stardard to agree is a battle I'm not fighting.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rootable/tomato!58
Reference in a new issue
rootable/tomato
No description provided.
Delete branch "el-rails-8"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?