5
11
Fork
You've already forked tomato
1

Updates to testing config #5

Merged
edwardloveall merged 7 commits from el-rspec-config into main 2025年08月05日 22:35:31 +02:00

This one is best reviewed commit by commit. Mostly I wanted to remove a bunch of comments from templates, and set up things a little closer to the way I use rspec.

This one is best reviewed commit by commit. Mostly I wanted to remove a bunch of comments from templates, and set up things a little closer to the way I use rspec.
thetizzo left a comment
Copy link

Love removing the comments from the RSpec config. Makes it much easier to read and understand how RSpec is configured.

Love removing the comments from the RSpec config. Makes it much easier to read and understand how RSpec is configured.
.rspec Outdated
@ -1,2 +1,3 @@
--color
--require spec_helper
--format documentation
First-time contributor
Copy link

I would be surprised if this is an issue with this size of test suite but for larger suites I've seen this output hit the log limit in CI. Something to keep in mind if the test suite grows.

I would be surprised if this is an issue with this size of test suite but for larger suites I've seen this output hit the log limit in CI. Something to keep in mind if the test suite grows.
Author
Owner
Copy link

Yeah, that's a good point. My last job we had far more tests and this didn't end up being a problem. You're probably right, but we've got a lot of headroom.

Yeah, that's a good point. My last job we had far more tests and this didn't end up being a problem. You're probably right, but we've got a lot of headroom.
@ -111,4 +52,0 @@
# Print the 10 slowest examples and example groups at the
# end of the spec run, to help surface which specs are running
# particularly slow.
config.profile_examples = 5
First-time contributor
Copy link

I sometimes like having these on in CI to see what my slowest overall tests are, but I agree that having this output on every single test run is unnecessary noise in the output.

I sometimes like having these on in CI to see what my slowest overall tests are, but I agree that having this output on every single test run is unnecessary noise in the output.
Author
Owner
Copy link

Oh, you know, I like that justification. I'll add it back in CI

Oh, you know, I like that justification. I'll add it back in CI
edwardloveall force-pushed el-rspec-config from ffc8594995
All checks were successful
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Successful
to 4caa673eab
Some checks failed
Setup Successful
Jest Successful
RSpec Failed
Static Analysis Successful
2025年08月05日 22:24:36 +02:00 Compare
Author
Owner
Copy link

Test flakes, but passes locally.

Test flakes, but passes locally.
edwardloveall deleted branch el-rspec-config 2025年08月05日 22:35:32 +02:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rootable/tomato!5
Reference in a new issue
rootable/tomato
No description provided.
Delete branch "el-rspec-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?