Ensure shift test doesn't create invalid event #49

edwardloveall commented 2025年11月18日 15:06:05 +01:00

The react shift form calculates the start time to the nearest half hour
to "now". It then sets the end time to 2 hours after that. If this test
is run between 10pm and 12am local time (or if local time converted to
UTC is in that range) the end time will be earlier than the start time.
This causes the test to fail.

The fix is to set the times manually. The value to set the time fields
is a bit odd: 03:00AM but it's sending those keys directly to the
field. If you were typing it by hand, you wouldn't add a space and so
we don't do that here for the same reason.

The react shift form calculates the start time to the nearest half hour to "now". It then sets the end time to 2 hours after that. If this test is run between 10pm and 12am local time (or if local time converted to UTC is in that range) the end time will be earlier than the start time. This causes the test to fail. The fix is to set the times manually. The value to set the time fields is a bit odd: `03:00AM` but it's sending those keys directly to the field. If you were typing it by hand, you wouldn't add a space and so we don't do that here for the same reason.

edwardloveall commented 2025年11月20日 21:17:16 +01:00

Thanks, Jesse! Those failing tests are flaky and pass locally on my machine.

Thanks, Jesse! Those failing tests are flaky and pass locally on my machine.