5
11
Fork
You've already forked tomato
1

Volunteer shift detail improvements #179

Merged
edwardloveall merged 5 commits from el-shift-juzh into main 2026年06月30日 17:05:25 +02:00

Note

This is probably a good one to review commit-by-commit

This adds a few improvements to the volunteer shift page to help volunteers do their volunteer work:

  • Show task logs in food taxonomy, weight, created_at order to make comparison across tasks easier
  • Move task log form to top of task so all the interactive parts are near each other
  • Give feedback that a event note was saved so volunteers know their input has been saved
> [!NOTE] > This is probably a good one to review commit-by-commit This adds a few improvements to the volunteer shift page to help volunteers do their volunteer work: - Show task logs in food taxonomy, weight, created_at order to make comparison across tasks easier - Move task log form to top of task so all the interactive parts are near each other - Give feedback that a event note was saved so volunteers know their input has been saved
This should help volunteers sort through and understand their log data more
easily.
We want them sorted by food taxonomy name, then weight (descending), then
created at in multiple places, so let's reuse that logic.
Volunteers often enter two pieces of data about a shift: transportation data,
and task logs. But the places to enter this data were far apart on the page.
This moves the task log form up just below the site address.
Give feedback that a event note was saved
Some checks failed
ci/woodpecker/pr/ci Pipeline failed
92cda20da9 
Similar to how we show feedback when setting the user notification setting[1],
We also got some feedback that saving transportation type or hours worked was
unclear. There's no submit button, so you just enter some info or click a button
and it's silently sent to the server.
This adds a check mark next to the fields so you know something happened.
[1]: Commit 16388f99 "Show confirmation after saving notification preference"
edwardloveall force-pushed el-shift-juzh from 92cda20da9
Some checks failed
ci/woodpecker/pr/ci Pipeline failed
to 3dc322f249
All checks were successful
ci/woodpecker/pr/ci Pipeline was successful
2026年06月29日 17:56:25 +02:00 Compare
@ -19,2 +18,3 @@
@task_logs = event.task_logs.in_display_order
if @task_log.errors.any?
if @task_logs.last.errors.any?
First-time contributor
Copy link

This only checks the last task log for errors because that is the one that was just created therefore it's the only one that could have errors?

This only checks the last task log for errors because that is the one that was just created therefore it's the only one that could have errors?
Author
Owner
Copy link

Yup!

Yup!
edwardloveall deleted branch el-shift-juzh 2026年06月30日 17:05:26 +02:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rootable/tomato!179
Reference in a new issue
rootable/tomato
No description provided.
Delete branch "el-shift-juzh"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?