5
11
Fork
You've already forked tomato
1

Fix tardy log end date range #168

Merged
edwardloveall merged 1 commit from el-fix-tardy-log-end-date into main 2026年06月10日 15:31:41 +02:00

We were passing in dates to the tardy logs report to get logs, but the range was
using dates, not times. This means than the range ends at the start of the
day. So if you ask for tardy logs between 2026年01月01日 and 2026年01月02日, the only
logs that would be included would be ones for events exactly at midnight in that
time zone.

We can use Rails' end_of_day method to fix that.

We were passing in dates to the tardy logs report to get logs, but the range was using dates, not times. This means than the range ends at the _start_ of the day. So if you ask for tardy logs between 2026年01月01日 and 2026年01月02日, the only logs that would be included would be ones for events exactly at midnight in that time zone. We can use Rails' `end_of_day` method to fix that.
Fix tardy log end date range
All checks were successful
ci/woodpecker/pr/ci Pipeline was successful
094f1530ac
We were passing in dates to the tardy logs report to get logs, but the range was
using dates, not times. This means than the range ends at the _start_ of the
day. So if you ask for tardy logs between 2026年01月01日 and 2026年01月02日, the only
logs that would be included would be ones for events exactly at midnight in that
time zone.
We can use Rails' `end_of_day` method to fix that.
edwardloveall force-pushed el-fix-tardy-log-end-date from 094f1530ac
All checks were successful
ci/woodpecker/pr/ci Pipeline was successful
to 68b4d7a485
All checks were successful
ci/woodpecker/pr/ci Pipeline was successful
2026年06月08日 20:27:19 +02:00
Compare
edwardloveall deleted branch el-fix-tardy-log-end-date 2026年06月10日 15:31:44 +02:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rootable/tomato!168
Reference in a new issue
rootable/tomato
No description provided.
Delete branch "el-fix-tardy-log-end-date"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?