5
11
Fork
You've already forked tomato
1

Task Log Reminders #156

Merged
edwardloveall merged 3 commits from el-task-log-reminders into main 2026年05月20日 15:19:24 +02:00

We want to send opt-in task log reminders 48 hours after the end of a task.
We're accomplishing that here with a mailer (obviously) and a background job
that will run every hour at 58 minutes past the hour.

I decided to make a recurring job instead of scheduling a future job because
scheduling would require that the code track any changes to events; already the
most complex and bug-prone part of the codebase.

I picked minute 58 because most events happen on the hour and then a handful on
15m boundaries. If we did it on the hour, a job running a second early or late
could miss events. Running 2m before the hour makes it far more likely that
we'll catch all the events, even if the processing time is off by a little, but
they'll still be delivered approximately 48h later.

We want to send opt-in task log reminders 48 hours after the end of a task. We're accomplishing that here with a mailer (obviously) and a background job that will run every hour at 58 minutes past the hour. I decided to make a recurring job instead of scheduling a future job because scheduling would require that the code track any changes to events; already the most complex and bug-prone part of the codebase. I picked minute 58 because most events happen on the hour and then a handful on 15m boundaries. If we did it on the hour, a job running a second early or late could miss events. Running 2m before the hour makes it far more likely that we'll catch all the events, even if the processing time is off by a little, but they'll still be delivered approximately 48h later.
edwardloveall force-pushed el-task-log-reminders from b4a2ab1b88
Some checks failed
ci/woodpecker/pr/ci Pipeline failed
to bfcfbdb542
Some checks failed
ci/woodpecker/pr/ci Pipeline failed
2026年05月14日 15:43:11 +02:00
Compare
edwardloveall force-pushed el-task-log-reminders from bfcfbdb542
Some checks failed
ci/woodpecker/pr/ci Pipeline failed
to 910ea22384
Some checks failed
ci/woodpecker/pr/ci Pipeline failed
2026年05月19日 15:26:40 +02:00
Compare
edwardloveall force-pushed el-task-log-reminders from 910ea22384
Some checks failed
ci/woodpecker/pr/ci Pipeline failed
to 3d36b0e9f9
Some checks failed
ci/woodpecker/pr/ci Pipeline failed
2026年05月19日 16:34:56 +02:00
Compare
Author
Owner
Copy link

Test failure is a known flake that continues to haunt me

Test failure is a known flake that continues to haunt me
edwardloveall deleted branch el-task-log-reminders 2026年05月20日 15:22:28 +02:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rootable/tomato!156
Reference in a new issue
rootable/tomato
No description provided.
Delete branch "el-task-log-reminders"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?