5
11
Fork
You've already forked tomato
1

Ignore future users when calculating past users for shift #120

Merged
edwardloveall merged 1 commit from el-past-users-fix into main 2026年03月18日 19:59:18 +01:00

First, instead of calculating past users in the controller, we add
previous_users method to the shift summary.

Second, the method ensures that we don't look into the future when trying to
find past users. Mostly this is done by filtering the users we count as
"other" users to users that show up for events only int he past. Obvious in
hindsight.

First, instead of calculating past users in the controller, we add `previous_users` method to the shift summary. Second, the method ensures that we don't look into the _future_ when trying to find _past_ users. Mostly this is done by filtering the users we count as "other" users to users that show up for events only int he past. Obvious in hindsight.
edwardloveall force-pushed el-past-users-fix from 48885e73b9
Some checks failed
ci/woodpecker/pr/ci Pipeline failed
to c61d88efec
All checks were successful
ci/woodpecker/pr/ci Pipeline was successful
2026年03月18日 15:04:50 +01:00
Compare
edwardloveall force-pushed el-past-users-fix from c61d88efec
All checks were successful
ci/woodpecker/pr/ci Pipeline was successful
to 6499e2cf99
All checks were successful
ci/woodpecker/pr/ci Pipeline was successful
2026年03月18日 19:54:27 +01:00
Compare
edwardloveall changed target branch from el-representative-event-change to main 2026年03月18日 19:58:18 +01:00
Author
Owner
Copy link

We'd like to get this bug fix out so I'm going to merge this. As usual, feel free to review even after it's merged.

We'd like to get this bug fix out so I'm going to merge this. As usual, feel free to review even after it's merged.
edwardloveall deleted branch el-past-users-fix 2026年03月18日 19:59:19 +01:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rootable/tomato!120
Reference in a new issue
rootable/tomato
No description provided.
Delete branch "el-past-users-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?