Splitting events with defined counts honors the remaining count #10

edwardloveall commented 2025年08月07日 23:21:51 +02:00

Fixes https://gitlab.com/food-rescue-alliance/tomato/-/issues/238

1. Create a recurring shift with a defined count (say 4)
2. Update a shift part way through the count (say 3rd) and chose "this and following events"

You'd get 4 new shifts plus the 2 shifts before the edited one. Not great!

The problem was that editing "this and following" duplicated the event properties, including the rrule which includes the UNTIL attribute unchanged. It knew to modify the old event to stop at a particular date, but not the new one.

The fix came in three parts:

• The old event's COUNT is removed (along with the UNTIL still being set)
• The new event's remaining COUNT is calculated
• If the user also updated the recurring options in the UI, we ignore the new COUNT and just use what they passed in.

Fixes https://gitlab.com/food-rescue-alliance/tomato/-/issues/238 1. Create a recurring shift with a defined count (say 4) 2. Update a shift part way through the count (say 3rd) and chose "this and following events" You'd get 4 _new_ shifts plus the 2 shifts before the edited one. Not great! The problem was that editing "this and following" duplicated the event properties, including the rrule which includes the `UNTIL` attribute unchanged. It knew to modify the old event to stop at a particular date, but not the new one. The fix came in three parts: * The old event's `COUNT` is removed (along with the `UNTIL` still being set) * The new event's remaining `COUNT` is calculated * If the user _also_ updated the recurring options in the UI, we ignore the new `COUNT` and just use what they passed in.

edwardloveall commented 2025年08月11日 15:50:00 +02:00

Yeah, you got it. RRule's are neat. Like you said they represent how an event can repeat and stop and exclude certain dates, etc. I found a good visualizer for them at https://jkbrzt.github.io/rrule/

And yes, recurrence_options is that string parsed into a hash.

Yeah, you got it. [RRule](https://datatracker.ietf.org/doc/html/rfc5545#autoid-100)'s are neat. Like you said they represent how an event can repeat and stop and exclude certain dates, etc. I found a good visualizer for them at https://jkbrzt.github.io/rrule/ And yes, `recurrence_options` is that [string parsed into a hash](https://codeberg.org/rootable/tomato/src/commit/0bb8c8a/app/models/event.rb#L39-L47).