Add missing LGPL-3.0-or-later license text #27

iamgreaser commented 2024年03月25日 01:52:21 +01:00

Picked up with reuse lint, did a reuse download --all and now we should be compliant for all the hiredict stuff.

Picked up with `reuse lint`, did a `reuse download --all` and now we should be compliant for all the hiredict stuff.

iamgreaser commented 2024年03月25日 01:54:40 +01:00

...oops, I had forgotten to sign it off. That should be fine now.

...oops, I had forgotten to sign it off. That *should* be fine now.

iamgreaser commented 2024年03月25日 02:00:47 +01:00

OK, under further investigation, there's a chance that the LGPL-3.0-or-later license tag may have been added in error - the dep5 information says LGPL-3.0-only, while all of the files with SPDX tags in hiredict are LGPL-3.0-or-later.

Which way should this go? Merging this would mean we're wanting to make the files LGPL-3.0-or-later. If not... a bit of find and sed -i may do the trick.

OK, under further investigation, there's a chance that the LGPL-3.0-or-later license tag may have been added in error - the dep5 information says LGPL-3.0-only, while all of the files with SPDX tags in hiredict are LGPL-3.0-or-later. Which way should this go? Merging this would mean we're wanting to make the files LGPL-3.0-or-later. If not... a bit of `find` and `sed -i` may do the trick.

lanodan commented 2024年03月25日 02:48:54 +01:00

Looking at it (git grep LGPL-3.0-or-later) it seems actually legit as it's from the vendored hiredict, which got put under LGPL-3.0-or-later (I guess for license compatibility reasons, it is a library after all).

Looking at it (`git grep LGPL-3.0-or-later`) it seems actually legit as it's from the vendored hiredict, which got put under `LGPL-3.0-or-later` (I guess for license compatibility reasons, it is a library after all).

navi commented 2024年03月25日 02:50:49 +01:00

redict is to be LGPL-3.0-only, and the redict files seem to have the right headers

tho, we're vendoring hiredict, the c client lib, which is LGPL-3.0-or-later, so maybe that's where it's coming from

(i got ninja'd by two minutes (削除) w (削除ここまで))

redict is to be `LGPL-3.0-only`, and the redict files seem to have the right headers tho, we're vendoring hiredict, the c client lib, which is `LGPL-3.0-or-later`, so maybe that's where it's coming from (i got ninja'd by two minutes ~w~)

iamgreaser commented 2024年03月25日 03:20:31 +01:00

Alright, in that case .reuse/dep5 will need to be updated soon afterwards if this gets merged.

Speaking of which, do we need everything to be in the dep5 file and the source files?

Alright, in that case `.reuse/dep5` will need to be updated soon afterwards if this gets merged. Speaking of which, do we need everything to be in the `dep5` file *and* the source files?

lanodan commented 2024年03月25日 04:31:40 +01:00

Speaking of which, do we need everything to be in the dep5 file and the source files?

Nope, in fact reuse 2.1.0 here warns against duplicated entries, and IIRC the REUSE specification is pretty clear that .reuse/dep5 should only be used as a fallback.

> Speaking of which, do we need everything to be in the dep5 file and the source files? Nope, in fact reuse 2.1.0 here warns *against* duplicated entries, and IIRC the REUSE specification is pretty clear that `.reuse/dep5` should only be used as a fallback.

ddevault commented 2024年03月25日 12:24:44 +01:00

Thanks!

Thanks!