redict/hiredict
5
5
Fork
You've already forked hiredict
3

test_blocking_connection_errors: use gai_strerror() over string matching #42

Open
lanodan wants to merge 1 commit from lanodan/hiredict:gai_strerror into main
pull from: lanodan/hiredict:gai_strerror
merge into: redict:main
redict:main
First-time contributor
Copy link

EAI_AGAIN and EAI_NONAME do not match between glibc and musl, among others:

== glibc 2.41 ==
EAI_AGAIN: Temporary failure in name resolution
EAI_BADFLAGS: Bad value for ai_flags
EAI_FAIL: Non-recoverable failure in name resolution
EAI_FAMILY: ai_family not supported
EAI_MEMORY: Memory allocation failure
EAI_NONAME: Name or service not known
EAI_OVERFLOW: Result too large for supplied buffer
EAI_SERVICE: Servname not supported for ai_socktype
EAI_SOCKTYPE: ai_socktype not supported
EAI_SYSTEM: System error

== musl 1.2.5 ==
EAI_AGAIN: Try again
EAI_BADFLAGS: Invalid flags
EAI_FAIL: Non-recoverable error
EAI_FAMILY: Unrecognized address family or invalid length
EAI_MEMORY: Out of memory
EAI_NODATA: Name has no usable address
EAI_NONAME: Name does not resolve
EAI_OVERFLOW: Overflow
EAI_SERVICE: Unrecognized service
EAI_SOCKTYPE: Unrecognized socket type
EAI_SYSTEM: System error

EAI_AGAIN and EAI_NONAME do not match between glibc and musl, among others: == glibc 2.41 == EAI_AGAIN: Temporary failure in name resolution EAI_BADFLAGS: Bad value for ai_flags EAI_FAIL: Non-recoverable failure in name resolution EAI_FAMILY: ai_family not supported EAI_MEMORY: Memory allocation failure EAI_NONAME: Name or service not known EAI_OVERFLOW: Result too large for supplied buffer EAI_SERVICE: Servname not supported for ai_socktype EAI_SOCKTYPE: ai_socktype not supported EAI_SYSTEM: System error == musl 1.2.5 == EAI_AGAIN: Try again EAI_BADFLAGS: Invalid flags EAI_FAIL: Non-recoverable error EAI_FAMILY: Unrecognized address family or invalid length EAI_MEMORY: Out of memory EAI_NODATA: Name has no usable address EAI_NONAME: Name does not resolve EAI_OVERFLOW: Overflow EAI_SERVICE: Unrecognized service EAI_SOCKTYPE: Unrecognized socket type EAI_SYSTEM: System error
EAI_AGAIN and EAI_NONAME do not match between glibc and musl, among others:
== glibc 2.41 ==
EAI_AGAIN: Temporary failure in name resolution
EAI_BADFLAGS: Bad value for ai_flags
EAI_FAIL: Non-recoverable failure in name resolution
EAI_FAMILY: ai_family not supported
EAI_MEMORY: Memory allocation failure
EAI_NONAME: Name or service not known
EAI_OVERFLOW: Result too large for supplied buffer
EAI_SERVICE: Servname not supported for ai_socktype
EAI_SOCKTYPE: ai_socktype not supported
EAI_SYSTEM: System error
== musl 1.2.5 ==
EAI_AGAIN: Try again
EAI_BADFLAGS: Invalid flags
EAI_FAIL: Non-recoverable error
EAI_FAMILY: Unrecognized address family or invalid length
EAI_MEMORY: Out of memory
EAI_NODATA: Name has no usable address
EAI_NONAME: Name does not resolve
EAI_OVERFLOW: Overflow
EAI_SERVICE: Unrecognized service
EAI_SOCKTYPE: Unrecognized socket type
EAI_SYSTEM: System error
ddevault left a comment
Copy link

+1

+1
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u gai_strerror:lanodan-gai_strerror
git switch lanodan-gai_strerror

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff lanodan-gai_strerror
git switch lanodan-gai_strerror
git rebase main
git switch main
git merge --ff-only lanodan-gai_strerror
git switch lanodan-gai_strerror
git rebase main
git switch main
git merge --no-ff lanodan-gai_strerror
git switch main
git merge --squash lanodan-gai_strerror
git switch main
git merge --ff-only lanodan-gai_strerror
git switch main
git merge lanodan-gai_strerror
git push origin main
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
redict/hiredict!42
Reference in a new issue
redict/hiredict
No description provided.
Delete branch "lanodan/hiredict:gai_strerror"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?