raiguard/MouseOverConstruction
4
0
Fork
You've already forked MouseOverConstruction
1

Update to Factorio 2.0 #16

Closed
target-san wants to merge 4 commits from update-2.0 into trunk
pull from: update-2.0
merge into: raiguard:trunk
raiguard:trunk
raiguard:insertion
target-san commented 2024年11月05日 18:39:11 +01:00 (Migrated from github.com)
Copy link
  • Checked on Factorio 2.0 & Space Age
  • Construction, deconstruction, repair, restoration, upgrade work as expected
  • Quality handling works as expected - entity constructed/restored correctly, upgrade works for type, quality and both changed
* Checked on Factorio 2.0 & Space Age * Construction, deconstruction, repair, restoration, upgrade work as expected * Quality handling works as expected - entity constructed/restored correctly, upgrade works for type, quality and both changed
target-san commented 2024年11月07日 10:59:45 +01:00 (Migrated from github.com)
Copy link

The only shortcoming I found out and which seems to be caused by engine is that when ghost and normal entity overlap, ghost is preferred as selected entity under cursor. As a result, auto-construct cannot do its job since you cannot place ghost first and only then remove existing entity, obviously. The same issues goes with normal manual (de)construction. It may actually be nice to either add toggle to change priorities or allow picking all entities under cursor.

The only shortcoming I found out and which seems to be caused by engine is that when ghost and normal entity overlap, ghost is preferred as selected entity under cursor. As a result, auto-construct cannot do its job since you cannot place ghost first and only then remove existing entity, obviously. The same issues goes with normal manual (de)construction. It may actually be nice to either add toggle to change priorities or allow picking all entities under cursor.
raiguard commented 2024年12月17日 01:52:07 +01:00 (Migrated from github.com)
Copy link

Oh sorry, I missed the PR. I updated it myself and pushed v1.3.0.

Thanks!

Oh sorry, I missed the PR. I updated it myself and pushed v1.3.0. Thanks!
target-san commented 2024年12月17日 14:36:03 +01:00 (Migrated from github.com)
Copy link

When porting, I discovered that tile ghosts are ignored. Probably because only entity-ghost's are processed. Didn't have time to investigate and fix.

When porting, I discovered that tile ghosts are ignored. Probably because only `entity-ghost`'s are processed. Didn't have time to investigate and fix.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
raiguard/MouseOverConstruction!16
Reference in a new issue
raiguard/MouseOverConstruction
No description provided.
Delete branch "update-2.0"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?