scroll exactly the remaining of the last page #2

taquangtrung commented 2024年06月24日 20:06:57 +02:00 (Migrated from github.com)

Hi,

Currently, when pdf-roll-mode is enabled, the last page can be over-scrolled to half of the displayed window: the last page is displayed at the top-half, while the bottom-half of the window is empty.

I fixed this issue so that the last page is scrolled to fit exactly the window (when the page is zoomed bigger than a window).

Can you review and merge this PR?
Thanks!

Hi, Currently, when `pdf-roll-mode` is enabled, the last page can be over-scrolled to half of the displayed window: the last page is displayed at the top-half, while the bottom-half of the window is empty. I fixed this issue so that the last page is scrolled to fit exactly the window (when the page is zoomed bigger than a window). Can you review and merge this PR? Thanks!

aikrahguzar commented 2024年07月05日 15:56:11 +02:00 (Migrated from github.com)

@taquangtrung, somehow I never got a notification about this and only saw this accidentally. The behavior you mentioned was deliberate on my part. I think it serves as a visual indication of the end of document.

Considering the usual Emacs behavior, I will be surprised if I can scroll at least a little bit past the end of buffer.

If you really want to be able to not get passed the end of buffer, I think a customizable option is better.

@taquangtrung, somehow I never got a notification about this and only saw this accidentally. The behavior you mentioned was deliberate on my part. I think it serves as a visual indication of the end of document. Considering the usual Emacs behavior, I will be surprised if I can scroll at least a little bit past the end of buffer. If you really want to be able to not get passed the end of buffer, I think a customizable option is better.

taquangtrung commented 2024年07月13日 09:28:28 +02:00 (Migrated from github.com)

My patch still doesn't work well for slides or when displaying multiple pages in the same window: the last page is displayed at the top of the window, leaving an empty space below it.

I guess it's the nature of pdf-roll, so, I'll close this PR.

Thanks the clarification previously!

My patch still doesn't work well for slides or when displaying multiple pages in the same window: the last page is displayed at the top of the window, leaving an empty space below it. I guess it's the nature of pdf-roll, so, I'll close this PR. Thanks the clarification previously!