Avoid crash in 'unsplit' #69

raboof commented 2023年07月16日 15:21:22 +02:00

When the target sibling doesn't allow children.

Possibly even better would be to insert a tabbed container in this case,
but leaving that for a future improvement.

Fixes #68

When the target sibling doesn't allow children. Possibly even better would be to insert a tabbed container in this case, but leaving that for a future improvement. Fixes #68

edmonds commented 2023年07月16日 20:42:08 +02:00

I'd omit the function names from the log messages sway_log(..."do_unsplit: "...); and sway_log(..."container_add_child: "...);. The sway_log() macro already adds the source filename and line number which is enough to identify where the log message was generated, and the general style in the Sway code base seems to be to omit function names from log messages. But if adding the function name to the log messages is useful maybe the sway_log() macro itself should also log the value of __func__ so the function name gets logged for every log message.

I'd omit the function names from the log messages `sway_log(..."do_unsplit: "...);` and `sway_log(..."container_add_child: "...);`. The `sway_log()` macro already adds the source filename and line number which is enough to identify where the log message was generated, and the general style in the Sway code base seems to be to omit function names from log messages. But if adding the function name to the log messages is useful maybe the `sway_log()` macro itself should also log the value of `__func__` so the function name gets logged for every log message.