'move tab' command #63

raboof commented 2023年07月04日 08:58:49 +02:00

fixes #16

fixes #16

edmonds commented 2023年07月04日 22:24:24 +02:00

OK, so the difference between "move tab" and the existing "move container" / "move window" syntax is that a "tab" is a specific kind of container whose parent is an L_TABBED container. OK, seems fine.

I'd use "position" rather than "index" since the parameter is 1-indexed.

Some of the existing syntax supports "to", I guess to let it sound more natural? E.g. move workspace [to] output up|right|down|left.

So I guess maybe the syntax could be something like:

move tab left|right
move tab to position <number>

Maybe a little more future-proof in case the syntax gets extended in the future.

OK, so the difference between "move tab" and the existing "move container" / "move window" syntax is that a "tab" is a specific kind of container whose parent is an `L_TABBED` container. OK, seems fine. I'd use "position" rather than "index" since the parameter is 1-indexed. Some of the existing syntax supports "to", I guess to let it sound more natural? E.g. `move workspace [to] output up|right|down|left`. So I guess maybe the syntax could be something like: ``` move tab left|right move tab to position <number> ``` Maybe a little more future-proof in case the syntax gets extended in the future.

edmonds commented 2023年07月04日 22:27:48 +02:00

This constant at the top of the file should be updated with the new syntax:

static const char expected_syntax[] =
	"Expected 'move <left|right|up|down> <[px] px>' or "
	"'move [--no-auto-back-and-forth] <container|window> [to] workspace <name>' or "
	"'move <container|window|workspace> [to] output <name|direction>' or "
	"'move <container|window> [to] mark <mark>'";

And I guess the volare(5) manpage too.

This constant at the top of the file should be updated with the new syntax: ```c static const char expected_syntax[] = "Expected 'move <left|right|up|down> <[px] px>' or " "'move [--no-auto-back-and-forth] <container|window> [to] workspace <name>' or " "'move <container|window|workspace> [to] output <name|direction>' or " "'move <container|window> [to] mark <mark>'"; ``` And I guess the volare(5) manpage too.

raboof commented 2023年07月05日 00:21:49 +02:00

OK, so the difference between "move tab" and the existing "move container" / "move window" syntax is that a "tab" is a specific kind of container whose parent is an L_TABBED container. OK, seems fine.

Yes, and specifically going 'right' or 'left' past the last/first tab will 'wrap around' within the tabbed container instead of jumping to the next/previous container.

I'd use "position" rather than "index" since the parameter is 1-indexed.

Some of the existing syntax supports "to", I guess to let it sound more natural? E.g. move workspace [to] output up|right|down|left.

So I guess maybe the syntax could be something like:

move tab left|right
move tab to position <number>

Hmm, makes sense - perhaps even move container [to] tab <position|direction>?

> OK, so the difference between "move tab" and the existing "move container" / "move window" syntax is that a "tab" is a specific kind of container whose parent is an `L_TABBED` container. OK, seems fine. Yes, and specifically going 'right' or 'left' past the last/first tab will 'wrap around' within the tabbed container instead of jumping to the next/previous container. > I'd use "position" rather than "index" since the parameter is 1-indexed. > > Some of the existing syntax supports "to", I guess to let it sound more natural? E.g. `move workspace [to] output up|right|down|left`. > > So I guess maybe the syntax could be something like: > > ``` > move tab left|right > move tab to position <number> > ``` Hmm, makes sense - perhaps even `move container [to] tab <position|direction>`?

edmonds commented 2023年07月05日 00:27:26 +02:00

Hmm, makes sense - perhaps even move container [to] tab <position|direction>?

I like move tab ... instead of move container ... because it doesn't operate on arbitrary containers.

> Hmm, makes sense - perhaps even `move container [to] tab <position|direction>`? I like `move tab ...` instead of `move container ...` because it doesn't operate on arbitrary containers.