8
0
Fork
You've already forked pEpJSONServerAdapter
0

Makefile: more fixes. #1

Closed
msc wants to merge 1 commit from master into master
pull from: master
merge into: pEp:master
pEp:gitea-12
pEp:master+sequoia_openpgp_ffi
pEp:Release_2.1
pEp:old-retired-Release_3.1
pEp:JSON-202
pEp:JSON-203
pEp:JSON-200
pEp:JSON-198
pEp:JSON-199
pEp:lucasaiu/message-struct-change
pEp:JSON-955
pEp:MACOSINST-26
pEp:JSON-192
pEp:JSON-186
pEp:JSON-128
pEp:JSON-183
pEp:JSON-182
pEp:JSON-180
pEp:JSON-172
pEp:JSON-160
pEp:JSON-156
pEp:ENGINE-857
pEp:JSON-170
pEp:pEp4Thunderbird
pEp:new_sync
pEp:JSON-153
pEp:JSON-153_experimental
pEp:JSON-155
pEp:old_session_management
pEp:JSON-98
pEp:JSON-111
pEp:JSON-107
pEp:JSON-142
pEp:JSON-134
pEp:JSON-147
pEp:postrelease
pEp:JSON-152
pEp:default-01
pEp:new_session_management
pEp:JSON-143
pEp:sync
pEp:JSON-62
pEp:JSON-141
pEp:JSON-139
pEp:JSON-131
pEp:JSON-127
pEp:JSON-123
pEp:JSON-107-01
pEp:JSON-79
pEp:JSON-114
pEp:python-wrapper
pEp:JSON-54
pEp:JSON-104
pEp:JSON-102
pEp:JSON-108
pEp:JSON-110
pEp:JSON-106
pEp:JSON-103
pEp:JSON-97
pEp:JSON-105
pEp:JSON-101
pEp:JSON-90
pEp:JSON-95
pEp:JSON-93
pEp:JSON-92
pEp:JSON-80
pEp:JSON-75
pEp:JSON-75-01
pEp:JSON-77
pEp:JSON-71
pEp:JSON-50
pEp:JSON-59
pEp:JSON-23
pEp:JSON-57
pEp:JSON-35
pEp:JSON-28
pEp:JSON-30
pEp:JSON-32
pEp:ENGINE-9
pEp:ENGINE-187
pEp:JSON-27
pEp:JSON-15
pEp:JSON-2
pEp:no_SessionID_in_API
pEp:as-a-library
pEp:refactor-result-recursion
Copy link
  • Don't use implicit rules. Thy hide bugs.
  • Build release builds with debug symbols.
  • Fix install/uninstall.
- Don't use implicit rules. Thy hide bugs. - Build release builds with debug symbols. - Fix install/uninstall.
Copy link

Roker: please integrate marcels changes, but not the removal of the implicit rules as it contradicts with adapter-land-makefile-style-guide: "We make use of implicit rules to the extent possible."

Roker: please integrate marcels changes, but not the removal of the implicit rules as it contradicts with adapter-land-makefile-style-guide: "We make use of implicit rules to the extent possible."
Copy link

...because we like our makefiles, short, pretty and standard.

...because we like our makefiles, short, pretty and standard.
Copy link

we will never see this in any of the makefiles we maintain:
MAKEFLAGS += --no-builtin-rules

we will never see this in any of the makefiles we maintain: MAKEFLAGS += --no-builtin-rules
Copy link

@heck

we will never see this in any of the makefiles we maintain:

Maybe write that down somewhere? Though tbh I have no idea where one would write that down, so maybe it is there already. Maybe also write down where such things are written down... Front page of https://dev.pep.security/ maybe?

@heck > we will never see this in any of the makefiles we maintain: Maybe write that down somewhere? Though tbh I have no idea where one would write that down, so maybe it is there already. Maybe also write down *where* such things are written down... Front page of https://dev.pep.security/ maybe?
Copy link

it is written down. i assumed you have read it yourself...
https://pep.foundation/jira/browse/JSON-193

but, marcel, you should not have to worry about this, since you are not part of the adapter team. (or are you and i dont know it___?)

It is Rokers job to mantain the makefiles for the pEpJSONAdapter.

I thought about making a wiki page, but since i dont have 20 people in my team, but more like 2 or so... i might do it, still...

it is written down. i assumed you have read it yourself... https://pep.foundation/jira/browse/JSON-193 but, marcel, you should not have to worry about this, since you are not part of the adapter team. (or are you and i dont know it___?) It is Rokers job to mantain the makefiles for the pEpJSONAdapter. I thought about making a wiki page, but since i dont have 20 people in my team, but more like 2 or so... i might do it, still...
Copy link

Well, JSON-193 and this PR where kind of concurrent. But yes, things do get written down, and that is great!

And no, I am not part of the adapter team, I am not in any way responsible for that, but it is still very much my problem. I guess I was in a deployment role for a while, but also as a developer, I need to compile adapters on sometimes weird platforms and that involves fixing the Makefiles as required. I could open a ticket for each of the problems, but fixing it myself is just much faster.

So that might explain why I am not aware of the Adapter Makefile conventions, and that is I think a very good reason why they should be documented in an easy to find place (which, ofc, we need to agree on company/project wide).

Ofc this is really not at all about the changes in this PR and also not really just about adapter Makefiles. More like, in general, documentation is not for the people who have to deal with sth. every day (they tend to know stuff), but for the people for whom whatever is just yet another thing that needs to get out of the way before the actual work can start.

Well, JSON-193 and this PR where kind of concurrent. But yes, things do get written down, and that is great! And no, I am not part of the adapter team, I am not in any way *responsible* for that, but it is still very much my problem. I guess I was in a deployment role for a while, but also as a developer, I need to compile adapters on sometimes weird platforms and that involves fixing the Makefiles as required. I could open a ticket for each of the problems, but fixing it myself is just _much_ faster. So that might explain why I am not aware of the Adapter Makefile conventions, and that is I think a very good reason why they should be documented in an easy to find place (which, ofc, we need to agree on company/project wide). Ofc this is really not at all about the changes in this PR and also not really just about adapter Makefiles. More like, in general, documentation is not for the people who have to deal with sth. every day (they tend to know stuff), but for the people for whom _whatever_ is just yet another thing that needs to get out of the way before the actual work can start.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pEp/pEpJSONServerAdapter!1
Reference in a new issue
pEp/pEpJSONServerAdapter
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?