8
3
Fork
You've already forked pEpEngine
0

WIP: ENGINE-818 #45

Draft
joerg wants to merge 2 commits from joerg/Release_2.1 into Release_2.1
pull from: joerg/Release_2.1
merge into: pEp:Release_2.1
pEp:master
pEp:engine-236
pEp:transport-system
pEp:dz/zig_0.16.0
pEp:FEATURE-232
pEp:transport-system-bk-before-showing-volker
pEp:FEATURE-206
pEp:dz/install_headers_only
pEp:FEATURE-220
pEp:Release_3.4.0
pEp:FEATURE_213
pEp:management-db-20
pEp:rebuild
pEp:own-key-backup
pEp:Release_3.3.0
pEp:193-attempt-late-2025
pEp:debug-mime
pEp:mailing-lists
pEp:non-destructive-imap
pEp:pEpMIME-default
pEp:positron-nkls-mixnet
pEp:pep4tb_deploy_macos
pEp:positron-check-signature
pEp:positron-nkls-mixnet--backup--2023年07月19日
pEp:gitea-169
pEp:heck_idl_codegen
pEp:gitea-168
pEp:gitea-165
pEp:gitea-133
pEp:gitea-133-rebased-snapshot-2023年05月10日
pEp:gitea-133-rebased-snapshot
pEp:gitea-133-unrebased
pEp:archive/Release_3.2
pEp:dvn/ci/sqlite
pEp:nkls-mixnet
pEp:gitea-150
pEp:gitea-148
pEp:gitea-149
pEp:positron/dvn/ci-refactor2023
pEp:gitea-140
pEp:gitea-91
pEp:gitea-136
pEp:pepmime--renamed
pEp:Release_2.1
pEp:unexpire-test-keys
pEp:gitea-96
pEp:gitea-120--2.x
pEp:gitea-116--2.x
pEp:gitea-121
pEp:gitea-118--3.x
pEp:gitea-113
pEp:gitea-117
pEp:foo
pEp:gitea-116
pEp:heck/tmpbugfix
pEp:gitea-100
pEp:gitea-104
pEp:gitea-90
pEp:echo-rate-limit
pEp:gitea-105
pEp:Release_2.1--with-sequoia-openpgp/v1.13.0-probably-all-wrong
pEp:invalid-upgdade
pEp:allow-empty-username
pEp:gitea-102
pEp:gitea-99
pEp:doxygen-3.x
pEp:gitea-83-84--v3
pEp:gitea-83-84--v2
pEp:gitea-83-84--v3--old-and-probably-useless
pEp:backup-before-using-REQUIRE
pEp:some-RCs-from-3.x--3.2.0-RC8-to-3.2.0-RC10
pEp:newsequoia2022--bk-2022年10月12日
pEp:log-scratch
pEp:mscgen
pEp:ENGINE-1006-for-engine-v2
pEp:sqlite-cleanup
pEp:ENGINE-1006-for-engine-v2-rebasing--backup-before-cleaning-2022年08月10日
pEp:ENGINE-999
pEp:ENGINE-1006-for-engine-v3--bk-before-rebasing
pEp:ENGINE-1006-for-engine-v3
pEp:ENGINE-1001--2.x
pEp:ENGINE-1001--3.x
pEp:ENGINE-1002--2.x
pEp:ENGINE-1002--3.x
pEp:positron/tka-scratch
pEp:positron/ENGINE-899
pEp:2.1-doxygen-docs
pEp:ENGINE-995
pEp:big-rewrite
pEp:migration-debugging
pEp:2.1-fix-two-lines-patch-only
pEp:ENGINE-996
pEp:QA-180
pEp:ENGINE-900
pEp:positron-temporary-for-heck-2022年01月12日-a
pEp:ENGINE-989
pEp:ENGINE-979-for-engine-v2
pEp:ENGINE-979-for-engine-v3
pEp:ENGINE-984
pEp:ENGINE-930
pEp:ENGINE-959
pEp:ENGINE-959-new-part-to-be-pushed-to-the-old-branch
pEp:ENGINE-975
pEp:ENGINE-969
pEp:ENGINE-971
pEp:ENGINE-969--almost-certainly-wrongly-named-and-useless--to-be-removed
pEp:ENGINE-974
pEp:ENGINE-972
pEp:ENGINE-968
pEp:ENGINE-619
pEp:lucasaiu/WIP-ENGINE-968
pEp:ENGINE-967
pEp:lucasaiu/test
pEp:ENGINE-964
pEp:ENGINE-956
pEp:lucasaiu/message-struct-change
pEp:ENGINE-961
pEp:ENGINE-962
pEp:lucasaiu/rating-field
pEp:Release_3.1
pEp:ENGINE-958
pEp:ENGINE-847
pEp:ENGINE-558
pEp:ENGINE-957
pEp:ENGINE-955
pEp:ENGINE-848
pEp:ENGINE-570
pEp:ENGINE-953
pEp:ENGINE-954
pEp:ENGINE-899
pEp:ENGINE-898
pEp:2.1_audit_refresh
pEp:doxygen_doc
pEp:generate_api
pEp:neal/sequoia-1.1
pEp:ENGINE-878
pEp:ENGINE-606
pEp:ENGINE-820
pEp:MACOSINST-33
pEp:MACOSINST-26
pEp:ENGINE-868
pEp:ENGINE-814
pEp:ENGINE-864
pEp:mime-integrate
pEp:trustsync
pEp:test-README.md
pEp:sync
pEp:pEpMIME_windows
pEp:pEpMIME--old--krista
pEp:nuanced_return_codes
pEp:key-manipulation-tests
pEp:fpr-format-check
pEp:extra_keys_add
pEp:elevated_attachments
pEp:doc_update_sequoia
pEp:doxygen-key-id
pEp:b0rken_crypto
pEp:audit_branch
pEp:add_key_notification
pEp:Release_2.1.0
pEp:ENGINE-871
pEp:ENGINE-872
pEp:ENGINE-641
Copy link

I tried looking at this.

As the comment says, maybe we should check other error codes. When asking Neal about which ones, he suggested that there might be a "real fix", see:

https://pep.foundation/jira/browse/ENGINE-818?focusedCommentId=40809&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-40809

Anyway, the patch improves the situation. The ticket also mentions setting PEP_ct_no_encryption. I'm not sure where that would need to be added.

I'm submitting this as PR for consideration.

I tried looking at this. As the comment says, maybe we should check other error codes. When asking Neal about which ones, he suggested that there might be a "real fix", see: https://pep.foundation/jira/browse/ENGINE-818?focusedCommentId=40809&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-40809 Anyway, the patch improves the situation. The ticket also mentions setting PEP_ct_no_encryption. I'm not sure where that would need to be added. I'm submitting this as PR for consideration.
positron commented 2023年04月27日 14:01:38 +02:00 (Migrated from gitea.pep.foundation)
Copy link

@joerg, thanks. Unfortunately we have seen this very late; I apologise.

Is this still relevant for Engine v3, and after such a long time?

Anyway I should write you a proper message and we should speak about the Thunderbird plugin.

In order to distinguish error status codes from non-error status codes we have a new function in the current Engine, PEP_STATUS_is_error. Unfortunately I do not see it wrapped in the JSON server adapter, but that would be very easy to solve.

@joerg, thanks. Unfortunately we have seen this very late; I apologise. Is this still relevant for Engine v3, and after such a long time? Anyway I should write you a proper message and we should speak about the Thunderbird plugin. In order to distinguish error status codes from non-error status codes we have a new function in the current Engine, `PEP_STATUS_is_error`. Unfortunately I do not see it wrapped in the JSON server adapter, but that would be very easy to solve.
Copy link

Unless you've fixed this in Engine 3, this is still relevant. Please look at the two commits above. The idea is to distinguish a general error from an error cause by the fact that SQ doesn't support a certain key, for example ElGamal. The summary says it all:

ENGINE-818: Distinguish "unsuitable key" from other errors when encrypting.

Both situations represent an error, so I don't know how the new function you mentioned (PEP_STATUS_is_error) would be helpful.

Unless you've fixed this in Engine 3, this is still relevant. Please look at the two commits above. The idea is to distinguish a general error from an error cause by the fact that SQ doesn't support a certain key, for example ElGamal. The summary says it all: ENGINE-818: Distinguish "unsuitable key" from other errors when encrypting. Both situations represent an error, so I don't know how the new function you mentioned (`PEP_STATUS_is_error`) would be helpful.
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin joerg/Release_2.1:joerg/Release_2.1
git switch joerg/Release_2.1

Merge

Merge the changes and update on Forgejo.
git switch Release_2.1
git merge --no-ff joerg/Release_2.1
git switch joerg/Release_2.1
git rebase Release_2.1
git switch Release_2.1
git merge --ff-only joerg/Release_2.1
git switch joerg/Release_2.1
git rebase Release_2.1
git switch Release_2.1
git merge --no-ff joerg/Release_2.1
git switch Release_2.1
git merge --squash joerg/Release_2.1
git switch Release_2.1
git merge --ff-only joerg/Release_2.1
git switch Release_2.1
git merge joerg/Release_2.1
git push origin Release_2.1
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pEp/pEpEngine!45
Reference in a new issue
pEp/pEpEngine
No description provided.
Delete branch "joerg/Release_2.1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?