Simplify the creation of xcframeworks from the engine source #225

dirkz commented 2026年01月28日 20:24:02 +01:00

• Mainly making variables more easy overridable with ?=.
• The change re install_name_tool is because the original fails on me, complaining about memory constraints in the library, and I'm not into the topic. I'm not using DESTDIR, so this call is unnecessary for my purposes. Any solution that avoids the error is welcome, this is just a double check to avoid the call if it doesn't look necessary anyways.

Update: Also contains xcode related changes.

* Mainly making variables more easy overridable with `?=`. * The change re `install_name_tool` is because the original fails on me, complaining about memory constraints in the library, and I'm not into the topic. I'm not using `DESTDIR`, so this call is unnecessary for my purposes. Any solution that avoids the error is welcome, this is just a double check to avoid the call if it doesn't look necessary anyways. Update: Also contains xcode related changes.

dirkz commented 2026年02月05日 12:55:11 +01:00

@lucasaiu @fdik Is there anything impeding a merge to master for this PR? Please let me know if I should change something. I'll have another engine PR soon regarding clang modules, and PRs on PRs (...) get confusing quickly.

@lucasaiu @fdik Is there anything impeding a merge to master for this PR? Please let me know if I should change something. I'll have another engine PR soon regarding clang modules, and PRs on PRs (...) get confusing quickly.

lucasaiu commented 2026年02月05日 13:09:15 +01:00

@dirkz wrote in #225 (comment):

@lucasaiu @fdik Is there anything impeding a merge to master for this PR? Please let me know if I should change something. I'll have another engine PR soon regarding clang modules, and PRs on PRs (...) get confusing quickly.

No, sorry, I was just concentrated on something else and not looking carefully enough at notifications. Thanks for pinging me.

@dirkz wrote in https://codeberg.org/pEp/pEpEngine/pulls/225#issuecomment-10382786: > @lucasaiu @fdik Is there anything impeding a merge to master for this PR? Please let me know if I should change something. I'll have another engine PR soon regarding clang modules, and PRs on PRs (...) get confusing quickly. No, sorry, I was just concentrated on something else and not looking carefully enough at notifications. Thanks for pinging me.