Use HTTPS for cape download #1

awruff commented 2026年01月26日 06:19:01 +01:00

Makes cape downloads use HTTPS... I didn't know whether or not if y'all would want this behind a config option so lmk

Uses https://optifine.net/capes/ rather than https://s.optifine.net/capes/ as sp614x said here

Makes cape downloads use HTTPS... I didn't know whether or not if y'all would want this behind a config option so lmk Uses `https://optifine.net/capes/` rather than `https://s.optifine.net/capes/` as sp614x said [here](https://github.com/sp614x/optifine/issues/4701#issuecomment-681624350)

owlsys commented 2026年01月26日 16:35:16 +01:00

There is little wrong with your idea in general. However, I think there are possible improvements regarding the implementation.

Ideally, you'd make use of @ModifyArg (on the usage of ofCapeUrl or on the StringBuilder#append that is used for the concat) or @ModifyVariable and then String#replace the old URL with the new one. This would allow other mods to also be able to modify this url if they desire without changes being silently overridden or the game crashing.

There is little wrong with your idea in general. However, I think there are possible improvements regarding the implementation. Ideally, you'd make use of `@ModifyArg` (on the usage of `ofCapeUrl` or on the `StringBuilder#append` that is used for the concat) or `@ModifyVariable` and then `String#replace` the old URL with the new one. This would allow other mods to also be able to modify this url if they desire without changes being silently overridden or the game crashing.

owlsys commented 2026年01月27日 09:02:22 +01:00

Thank you.

Thank you.