3
2
Fork
You've already forked timecheck
5

Fixed irregular indentation #8

Merged
nuron merged 2 commits from sdicke/timecheck:testing into testing 2020年05月18日 18:05:00 +02:00
Contributor
Copy link
No description provided.
timecheck.sh Outdated
@ -16,2 +13,2 @@
echo "You don't have enough permissions to perform this script. Please retry as root. Script execution aborted."
exit 1
INSTALL_USER=$(whoami)
if [ ! "$INSTALL_USER" = "root" ]
Owner
Copy link

Why would you intend the if and the following more?

Why would you intend the if and the following more?
Collaborator
Copy link

May be because @sdicke is using a auto formatter and the first if is missing a fi which is not needed for execution because of the exit, but it's needed for the auto formatter

May be because @sdicke is using a auto formatter and the first if is missing a `fi` which is not needed for execution because of the exit, but it's needed for the auto formatter
Owner
Copy link

There is an if in line 18?!
And of course it is needed. You must close the if part when it is done..

In my oppinion it does not make sense to intend this if block one step more..

There is an if in line 18?! And of course it is needed. You must close the if part when it is done.. In my oppinion it does not make sense to intend this if block one step more..
Collaborator
Copy link

Oh yes now I get it.... so yes @sdicke I would suggest to not indent the if block with two tabs...

Oh yes now I get it.... so yes @sdicke I would suggest to not indent the if block with two tabs...
Author
Contributor
Copy link

This indentation was a mistake.

This indentation was a mistake.
Collaborator
Copy link

Isn't this a duplicate of !7?

Isn't this a duplicate of !7?
Owner
Copy link

Isn't this a duplicate of !7?

The pull request is (I guess identical) for both branches.
So onetimes for master and a second time with (allmost) the same changes for testing.

> Isn't this a duplicate of !7? The pull request is (I guess identical) for both branches. So onetimes for master and a second time with (allmost) the same changes for testing.
Collaborator
Copy link

Isn't this a duplicate of !7?

The pull request is (I guess identical) for both branches.
So onetimes for master and a second time with (allmost) the same changes for testing.

Wow thats not how it should work.... maybe just keep the one for testing and later merge tesing into master?

> > Isn't this a duplicate of !7? > > The pull request is (I guess identical) for both branches. > So onetimes for master and a second time with (allmost) the same changes for testing. Wow thats not how it should work.... maybe just keep the one for testing and later merge tesing into master?
Owner
Copy link

As I said earlyer, I did not see any recent changes in the first 40 lines, so why shall I merge this?

As I said earlyer, I did not see any recent changes in the first 40 lines, so why shall I merge this?
Author
Contributor
Copy link

Wow thats not how it should work.... maybe just keep the one for testing and later merge tesing into master?

As I pushed the commit the master branch had more commits than the testing branch so I was unsure which branch to select.

> Wow thats not how it should work.... maybe just keep the one for testing and later merge tesing into master? As I pushed the commit the master branch had more commits than the testing branch so I was unsure which branch to select.
Collaborator
Copy link

Wow thats not how it should work.... maybe just keep the one for testing and later merge tesing into master?

As I pushed the commit the master branch had more commits than the testing branch so I was unsure which branch to select.

I would suggest to just do a PR to the testing branch and later we will also merge it into master...

> > Wow thats not how it should work.... maybe just keep the one for testing and later merge tesing into master? > > As I pushed the commit the master branch had more commits than the testing branch so I was unsure which branch to select. I would suggest to just do a PR to the testing branch and later we will also merge it into master...
nuron closed this pull request 2020年05月18日 18:05:00 +02:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nuron/timecheck!8
Reference in a new issue
nuron/timecheck
No description provided.
Delete branch "sdicke/timecheck:testing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?