Fix vue special-case mapping always matching #596

TheMageKing commented 2021年08月03日 03:51:04 +02:00

I live!

Had an issue with an over-eager special case (the line I changed matched on cdn.jsdelivr.net/npm/vue@2.5/dist/vue.js , which resulted in the version ID that was sent to the setLastVersion being simply "s", which didn't match any of the Vue interceptors and resulted in "false" being returned, so the redirect was to resources/vue/false/vue.min.jsm, which is obviously nonsense). I tested on both the original website reported in the issue that prompted this special case and the site which I had my issue with: both worked great.

The change I was talking about making a few months ago would have prevented this (or, rather, made the failure loud instead of silent), but I never got around to it. Accept this fix in the stead of that: I might still get around to it, but not now.

I live! Had an issue with an over-eager special case (the line I changed matched on cdn.jsdelivr.net/npm/vue@2.5/dist/vue.js , which resulted in the version ID that was sent to the setLastVersion being simply "s", which didn't match any of the Vue interceptors and resulted in "false" being returned, so the redirect was to resources/vue/false/vue.min.jsm, which is obviously nonsense). I tested on both the original website reported in the issue that prompted this special case and the site which I had my issue with: both worked great. The change I was talking about making a few months ago would have prevented this (or, rather, made the failure loud instead of silent), but I never got around to it. Accept this fix in the stead of that: I might still get around to it, but not now.

nobody commented 2021年08月03日 06:50:54 +02:00

Thanks for your PR. It doesn't work, unfortunately. I have already fixed that here: #598

Thanks for your PR. It doesn't work, unfortunately. I have already fixed that here: https://codeberg.org/nobody/LocalCDN/issues/598

TheMageKing commented 2021年08月03日 07:39:31 +02:00

What can I say: I was lazy, and just wanted the thing to stop being broken.

What can I say: I was lazy, and just wanted the thing to stop being broken.

nobody commented 2021年08月03日 08:26:53 +02:00

No problem. Could you test if the current develop works with the website?

No problem. Could you test if the current develop works with the website?

TheMageKing commented 2021年08月03日 19:45:44 +02:00

yup, its alive

yup, its alive

nobody commented 2021年08月05日 06:32:03 +02:00

Great, glad to see the problem is solved 🙂

Great, glad to see the problem is solved 🙂