Implement fallback for gen_version() #25

bwbuhse commented 2026年03月19日 02:37:31 +01:00

Building from a release tarball (without a .git directory) currently panics in release mode because gen_version and gen_version_info use try on git commands that fail. This changes the git calls to catch and falls back to manifest.version from build.zig.zon when git describe returns nothing. The committed: field is omitted when git history isn't available, and git-dependent fields (branch, diff, log) gracefully degrade to empty. This allows distro packagers to build from the release tarball without needing to fake a git repository.

Building from a release tarball (without a .git directory) currently panics in release mode because gen_version and gen_version_info use try on git commands that fail. This changes the git calls to catch and falls back to manifest.version from build.zig.zon when git describe returns nothing. The committed: field is omitted when git history isn't available, and git-dependent fields (branch, diff, log) gracefully degrade to empty. This allows distro packagers to build from the release tarball without needing to fake a git repository.

bwbuhse commented 2026年03月19日 15:12:18 +01:00

I didn't see the latest release was actually implementing the panic, so feel free to close this if I'm misunderstanding. My main thing was that I was trying to make an ebuild for Gentoo but because it just downloads the source tarball instead of cloning, it panics.

I didn't see the latest release was actually *implementing* the panic, so feel free to close this if I'm misunderstanding. My main thing was that I was trying to make an ebuild for Gentoo but because it just downloads the source tarball instead of cloning, it panics.

neurocyte commented 2026年04月13日 19:40:54 +02:00

The build error is intentional to help prevent producing release builds with partial version information. I don't think side stepping that is an improvement and it is not actually needed because you can just build without the --release flag, which is probably what you want for Gentoo. It might make sense to pre-generate the full version file for building from tarballs with no .git directory (although I personally don't see the point), but that is not what this change does anyway so I'm just going to close.

The build error is intentional to help prevent producing release builds with partial version information. I don't think side stepping that is an improvement and it is not actually needed because you can just build without the `--release` flag, which is probably what you want for Gentoo. It might make sense to pre-generate the full version file for building from tarballs with no `.git` directory (although I personally don't see the point), but that is not what this change does anyway so I'm just going to close.

neurocyte commented 2026年04月13日 19:41:37 +02:00

Hope you don't mind. Thanks anyway!

Hope you don't mind. Thanks anyway!