1
1
Fork
You've already forked zop
0

Release workflow: create missing dispatch tag via GitHub Release target commit #22

Merged
Copilot merged 8 commits from copilot/add-macos-arm64-build-target into main 2026年03月18日 07:21:06 +01:00
Copilot commented 2026年03月18日 05:19:40 +01:00 (Migrated from github.com)
Copy link

Manual releases currently assume the tag already exists. This updates the workflow so workflow_dispatch can release a new version without pre-creating/pushing a tag from a local machine.

  • Tag resolution now separates release tag from checkout ref

    • resolve-tag now outputs:
      • tag (requested/release tag name)
      • checkout_ref (what build/test jobs should check out)
      • target_commitish (commit the release tag should point to)
  • Missing-tag dispatch flow

    • If the tag exists: build/test/release continue on that tag.
    • If the tag is missing on workflow_dispatch: build/test run from github.sha, and release creation is instructed to create the tag at that commit.
  • Release creation owns tag creation

    • Removed manual git tag / git push behavior.
    • softprops/action-gh-release now receives target_commitish, allowing GitHub Release creation to create the tag when absent.
- name:Create releaseuses:softprops/action-gh-release@v2with:tag_name:${{ needs.resolve-tag.outputs.tag }}target_commitish:${{ needs.resolve-tag.outputs.target_commitish }}files:dist/*

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Manual releases currently assume the tag already exists. This updates the workflow so `workflow_dispatch` can release a new version without pre-creating/pushing a tag from a local machine. - **Tag resolution now separates release tag from checkout ref** - `resolve-tag` now outputs: - `tag` (requested/release tag name) - `checkout_ref` (what build/test jobs should check out) - `target_commitish` (commit the release tag should point to) - **Missing-tag dispatch flow** - If the tag exists: build/test/release continue on that tag. - If the tag is missing on `workflow_dispatch`: build/test run from `github.sha`, and release creation is instructed to create the tag at that commit. - **Release creation owns tag creation** - Removed manual `git tag` / `git push` behavior. - `softprops/action-gh-release` now receives `target_commitish`, allowing GitHub Release creation to create the tag when absent. ```yaml - name: Create release uses: softprops/action-gh-release@v2 with: tag_name: ${{ needs.resolve-tag.outputs.tag }} target_commitish: ${{ needs.resolve-tag.outputs.target_commitish }} files: dist/* ``` <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.
peterwwillis (Migrated from github.com) reviewed 2026年03月18日 05:19:40 +01:00
github-actions[bot] commented 2026年03月18日 05:51:34 +01:00 (Migrated from github.com)
Copy link

Mobile UI Screenshot

zop mobile UI

### Mobile UI Screenshot ![zop mobile UI](https://raw.githubusercontent.com/peterwwillis/zop/ui-screenshots/pr-22/zop-mobile-ui.png) <!-- Sticky Pull Request Commentzop-mobile-ui -->
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2026年03月18日 07:14:30 +01:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment
Copy link

Pull request overview

Updates the release GitHub Actions workflow so workflow_dispatch can create and publish a release even when the requested tag does not yet exist, by separating "release tag name" from the ref used to build/test and by delegating tag creation to the GitHub Release step.

Changes:

  • Add checkout_ref and target_commitish outputs to resolve a build/test ref and the commit a release tag should point to.
  • Update checkout steps in test/build/android/release jobs to use the resolved checkout_ref rather than always checking out the tag.
  • Pass target_commitish to softprops/action-gh-release so missing tags can be created during release creation; also adds darwin/arm64 build matrix entries.
## Pull request overview Updates the release GitHub Actions workflow so `workflow_dispatch` can create and publish a release even when the requested tag does not yet exist, by separating "release tag name" from the ref used to build/test and by delegating tag creation to the GitHub Release step. **Changes:** - Add `checkout_ref` and `target_commitish` outputs to resolve a build/test ref and the commit a release tag should point to. - Update checkout steps in test/build/android/release jobs to use the resolved `checkout_ref` rather than always checking out the tag. - Pass `target_commitish` to `softprops/action-gh-release` so missing tags can be created during release creation; also adds darwin/arm64 build matrix entries.
@ -191,0 +213,4 @@
git clone --depth 1 --branch v1.8.3 https://github.com/ggerganov/whisper.cpp internal/whisper/whisper.cpp
cmake -S internal/whisper/whisper.cpp \
-B internal/whisper/whisper.cpp/build \
-DCMAKE_BUILD_TYPE=Release \
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2026年03月18日 07:14:30 +01:00
Copy link

The PR description is focused on dispatch-created tags, but this workflow change also adds new darwin/arm64 build matrix entries. Please either (a) update the PR description to mention the macOS artifacts/runner requirement, or (b) split the macOS build addition into a separate PR so the release-tag behavior change can be reviewed and rolled out independently.

The PR description is focused on dispatch-created tags, but this workflow change also adds new darwin/arm64 build matrix entries. Please either (a) update the PR description to mention the macOS artifacts/runner requirement, or (b) split the macOS build addition into a separate PR so the release-tag behavior change can be reviewed and rolled out independently.
@ -191,3 +221,4 @@
cmake --build internal/whisper/whisper.cpp/build --target whisper
- name:Build
env:
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2026年03月18日 07:14:30 +01:00
Copy link

These new darwin/arm64 builds run on a self-hosted runner label set. Because the release job depends on the full build matrix, any missing/offline self-hosted runner will block the entire release workflow. If runner availability isn’t guaranteed, consider guarding these matrix entries behind an input/condition or moving them to a separate, non-blocking workflow/job.

These new darwin/arm64 builds run on a self-hosted runner label set. Because the `release` job depends on the full `build` matrix, any missing/offline self-hosted runner will block the entire release workflow. If runner availability isn’t guaranteed, consider guarding these matrix entries behind an input/condition or moving them to a separate, non-blocking workflow/job.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
mutablecc/zop!22
Reference in a new issue
mutablecc/zop
No description provided.
Delete branch "copilot/add-macos-arm64-build-target"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?