5
1
Fork
You've already forked apps
2

Remove kubeutil module and refactor error handling for Zitadel ConfigMap #8

Open
mre wants to merge 1 commit from mre/apps:cleanup-zitadel into main
pull from: mre/apps:cleanup-zitadel
merge into: monkey-wrench:main
monkey-wrench:main
monkey-wrench:renovate/zitadel-9.x
monkey-wrench:renovate/traefik-39.x
monkey-wrench:renovate/serde_with-3.x-lockfile
monkey-wrench:renovate/reqwest-0.x
monkey-wrench:renovate/cert-manager-1.x
monkey-wrench:wip
First-time contributor
Copy link

I found that it's cleaner without the custom unwrap_not_found. Also,
configmaps.get_opt() does the same as the custom implementation using
get(). It checks for 404.

Note however that I couldn't test the code, because I don't use Kubernetes; I was just curious about the Rust bits. :)

I found that it's cleaner without the custom `unwrap_not_found`. Also, `configmaps.get_opt()` does the same as the custom implementation using `get()`. It checks for 404. Note however that I couldn't test the code, because I don't use Kubernetes; I was just curious about the Rust bits. :)
code
I found that it's cleaner without the custom `unwrap_not_found`. Also,
`configmaps.get_opt()` does the same as the custom implementation using
`get()`. It checks for 404.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u cleanup-zitadel:mre-cleanup-zitadel
git switch mre-cleanup-zitadel

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff mre-cleanup-zitadel
git switch mre-cleanup-zitadel
git rebase main
git switch main
git merge --ff-only mre-cleanup-zitadel
git switch mre-cleanup-zitadel
git rebase main
git switch main
git merge --no-ff mre-cleanup-zitadel
git switch main
git merge --squash mre-cleanup-zitadel
git switch main
git merge --ff-only mre-cleanup-zitadel
git switch main
git merge mre-cleanup-zitadel
git push origin main
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
monkey-wrench/apps!8
Reference in a new issue
monkey-wrench/apps
No description provided.
Delete branch "mre/apps:cleanup-zitadel"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?