1
0
Fork
You've already forked smallQuery
0

wrap, wrapInner, wrapAll #47

Merged
moggers87 merged 1 commit from 35-wrap into master 2021年04月11日 19:02:33 +02:00
moggers87 commented 2020年10月19日 23:11:57 +02:00 (Migrated from github.com)
Copy link

This'll wrap up 🎉 0.0.4

This'll wrap up :tada: 0.0.4
codecov[bot] commented 2021年03月27日 01:06:10 +01:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #47 (92e500e) into master (b9f40ba) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@
## master #47 +/- ##
=========================================
 Coverage 100.00% 100.00% 
=========================================
 Files 6 6 
 Lines 203 230 +27 
=========================================
+ Hits 203 230 +27 
Impacted Files Coverage Δ
src/core.js 100.00% <100.00%> (ø)
src/dom.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f40ba...92e500e. Read the comment docs.

# [Codecov](https://codecov.io/gh/moggers87/smallQuery/pull/47?src=pr&el=h1) Report > Merging [#47](https://codecov.io/gh/moggers87/smallQuery/pull/47?src=pr&el=desc) (92e500e) into [master](https://codecov.io/gh/moggers87/smallQuery/commit/b9f40ba6d67214fb54e1899bd804abb776dfd810?el=desc) (b9f40ba) will **not change** coverage. > The diff coverage is `100.00%`. [![Impacted file tree graph](https://codecov.io/gh/moggers87/smallQuery/pull/47/graphs/tree.svg?width=650&height=150&src=pr&token=6eXeSoXoYc)](https://codecov.io/gh/moggers87/smallQuery/pull/47?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #47 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 6 6 Lines 203 230 +27 ========================================= + Hits 203 230 +27 ``` | [Impacted Files](https://codecov.io/gh/moggers87/smallQuery/pull/47?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/core.js](https://codecov.io/gh/moggers87/smallQuery/pull/47/diff?src=pr&el=tree#diff-c3JjL2NvcmUuanM=) | `100.00% <100.00%> (ø)` | | | [src/dom.js](https://codecov.io/gh/moggers87/smallQuery/pull/47/diff?src=pr&el=tree#diff-c3JjL2RvbS5qcw==) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/moggers87/smallQuery/pull/47?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/moggers87/smallQuery/pull/47?src=pr&el=footer). Last update [b9f40ba...92e500e](https://codecov.io/gh/moggers87/smallQuery/pull/47?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
moggers87 commented 2021年03月27日 01:08:33 +01:00 (Migrated from github.com)
Copy link

Tests need expanding:

  • wrapAll with different parents
  • with wrapping element that is 2 or more tags deep
  • with wrapping element that has a sibling (sibling should be ignored)
Tests need expanding: - wrapAll with different parents - with wrapping element that is 2 or more tags deep - with wrapping element that has a sibling (sibling should be ignored)
moggers87 commented 2021年03月27日 01:09:11 +01:00 (Migrated from github.com)
Copy link

Update README with how to run tests, including how to run with CI and/or without coverage if wanted.

Update README with how to run tests, including how to run with CI and/or without coverage if wanted.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
moggers87/smallQuery!47
Reference in a new issue
moggers87/smallQuery
No description provided.
Delete branch "35-wrap"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?