6
84
Fork
You've already forked dns
39

responsewriter hijack fixes #190

Closed
miekg wants to merge 1 commit from miek/tcp-hijack1 into main
pull from: miek/tcp-hijack1
merge into: miekg:main
miekg:main
miekg:miek/26/jul13ma/06
miekg:miek/26/mrt24di/tls
miekg:miek/26/mrt09ma/17
miekg:miek/26/feb15zo/13
miekg:miek/2025-10-26@1431
miekg:miek/2025-10-18@2017
Owner
Copy link

Signed-off-by: Miek Gieben miek@miek.nl

Signed-off-by: Miek Gieben <miek@miek.nl>
Init function for tests to remove lingering binaries
Some checks failed
ci/woodpecker/push/build Pipeline failed
ci/woodpecker/pr/build Pipeline failed
ci/woodpecker/pull_request_closed/build Pipeline was successful
48067c55a0 
Signed-off-by: Miek Gieben <miek@miek.nl>
miekg changed title from (削除) Init function for tests to remove lingering binaries (削除ここまで) to responsewriter hijack fixes 2025年09月16日 12:31:41 +02:00
Author
Owner
Copy link

this hangs in the tests due to deadlock?

this hangs in the tests due to deadlock?
Contributor
Copy link

I see a deadlock in TestServerMsgInvalidFunc. The test is stuck reading from the socket. SetReadDeadline doesn't seem to be set to unblock read on shutdown.

I see a deadlock in `TestServerMsgInvalidFunc`. The test is stuck reading from the socket. `SetReadDeadline` doesn't seem to be set to unblock read on shutdown.
Contributor
Copy link

This test passed before because wg.Add(1) was not called until a valid message was seen. Now wg.Add(1) is called at the very beginning and wg.Done(1) is not called until the reading loop is broken. Which never happens in the test as read timeout is longer than test timeout.

This test passed before because `wg.Add(1)` was not called until a valid message was seen. Now `wg.Add(1)` is called at the very beginning and `wg.Done(1)` is not called until the reading loop is broken. Which never happens in the test as read timeout is longer than test timeout.
miekg closed this pull request 2025年09月17日 07:22:53 +02:00
miekg deleted branch miek/tcp-hijack1 2025年09月17日 07:22:59 +02:00
Some checks failed
ci/woodpecker/push/build Pipeline failed
ci/woodpecker/pr/build Pipeline failed
ci/woodpecker/pull_request_closed/build Pipeline was successful

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
miekg/dns!190
Reference in a new issue
miekg/dns
No description provided.
Delete branch "miek/tcp-hijack1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?