Include the specific namespace error name in phase failure diagnostics #109

jhuntwork commented 2026年07月10日 19:24:25 +02:00

runOneNamespacePhase set a static "failed to fork and enter env" message
regardless of which of namespace.EnvError's ~20 variants (uid-map
failure, overlayfs unavailable, disabled user namespaces, mount
failures, etc.) actually occurred, with no way for an operator to tell
them apart from the message alone. Interpolate @errorName(err) into the
diagnostic details via setDiagnosticContextFmt instead of the static
string.

runOneNamespacePhase set a static "failed to fork and enter env" message regardless of which of namespace.EnvError's ~20 variants (uid-map failure, overlayfs unavailable, disabled user namespaces, mount failures, etc.) actually occurred, with no way for an operator to tell them apart from the message alone. Interpolate @errorName(err) into the diagnostic details via setDiagnosticContextFmt instead of the static string.