Adding a basic minor mode could make sentex easier to use. Moreover, should something like #1 land, it could more easily hook into forward-sentence-function through the use of a setq-local or similar.
Add a minor mode to locally remap sentence navigation commands #4
Merged
martianh
merged 1 commit from 2023年03月26日 21:48:54 +02:00
swflint/sentex:add-minor-mode into develop
swflint
commented 2023年03月25日 16:37:51 +01:00
Adding a basic minor mode could make `sentex` easier to use. Moreover, should something like #1 land, it could more easily hook into `forward-sentence-function` through the use of a `setq-local` or similar.
martianh
commented 2023年03月26日 19:20:50 +02:00
this is fine, thanks. (i was hesitant about clobbering the built-ins, but probably just out of shyness. it seems to make sense to people.)
but please PR against develop not main.
this is fine, thanks. (i was hesitant about clobbering the built-ins, but probably just out of shyness. it seems to make sense to people.)
but please PR against develop not main.
swflint
changed target branch from main to develop 2023年03月26日 19:50:09 +02:00
swflint
force-pushed add-minor-mode from 2023年03月26日 19:52:42 +02:00
Compare
25bbaeabf6
to 5a836a8058
swflint
commented 2023年03月26日 19:55:47 +02:00
PR is now against develop.
I went with using remap so that users of evil or similar can hopefully get the new bindings for free.
PR is now against `develop`.
I went with using `remap` so that users of `evil` or similar can hopefully get the new bindings for free.
martianh
commented 2023年03月26日 20:19:05 +02:00
yeah remapping in a minor mode seems good. then we can over-ride, but if it gets in the way, just disable.
yeah remapping in a minor mode seems good. then we can over-ride, but if it gets in the way, just disable.
martianh
merged commit 4a3dc633a6 into develop 2023年03月26日 21:48:54 +02:00
martianh
referenced this pull request from a commit 2023年03月26日 21:48:54 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
martianh/sentex!4
Loading...
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "swflint/sentex:add-minor-mode"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?