Add CSD / Windows Controls #15

Mr-nUUb commented 2022年02月23日 18:31:03 +01:00 (Migrated from github.com)

fixes #14

fixes #14

macleod commented 2022年02月23日 21:27:16 +01:00

I merged this into a new branch, I am making some changes later today that will help across the board for additional customizations, including yours. This is really great work.

I merged this into a new branch, I am making some changes later today that will help across the board for additional customizations, including yours. This is really great work.

macleod commented 2022年02月24日 01:38:46 +01:00

@Mr-nUUb Could you follow the new instructions in the readme (削除) on the 'extensions' branch (削除ここまで) and see if it works for you (削除) (you will need to switch the branch to the extensions branch after completing the clone step, of course)? (削除ここまで) I just merged it with the main branch.

I broke the extension into components (each component has their own file), I added a prefs.css file, and I made it so you can anable/disable tweaks and change settings. I am not having any issues on my side, but I hope that it works the same on yours.

This will also make it so that people can just clone the repo and stay up to date on it.

@Mr-nUUb Could you follow the new instructions in the readme ~~on the 'extensions' branch~~ and see if it works for you ~~(you will need to switch the branch to the extensions branch after completing the clone step, of course)?~~ I just merged it with the main branch. I broke the extension into components (each component has their own file), I added a prefs.css file, and I made it so you can anable/disable tweaks and change settings. I am not having any issues on my side, but I hope that it works the same on yours. This will also make it so that people can just clone the repo and stay up to date on it.

macleod commented 2022年02月24日 02:01:42 +01:00

I just merged it with the main branch (on accident, but I'll let it stand for the moment).

I just merged it with the main branch (on accident, but I'll let it stand for the moment).

Xanaxus commented 2022年02月24日 02:13:31 +01:00 (Migrated from github.com)

The line no 261 should be changed to 150px IMO as it render like this with 95px:
image
Which is not good according to me

And the line 269 also needs some changes as u can see the window control buttons are not in line with the home button/ prev, pg button, I have kept mine at 10px. Which I guess is due to my custom theme, so I guess a comment will be necessary so that the future users know that this the line which needs to be changed in order to achieve a same plane placement.

This how it looks with my tweaks:
image

The line no 261 should be changed to `150px` IMO as it render like this with `95px`:  Which is not good according to me And the line 269 also needs some changes as u can see the window control buttons are not in line with the home button/ prev, pg button, I have kept mine at 10px. Which I guess is due to my custom theme, so I guess a comment will be necessary so that the future users know that this the line which needs to be changed in order to achieve a same plane placement. This how it looks with my tweaks: 

macleod commented 2022年02月24日 02:16:44 +01:00

Are you using their PR or the changes I have made to this and implemented in the new version of the Repo? (there shouldnt be a line number 261 anymore)

Are you using their PR or the changes I have made to this and implemented in the new version of the Repo? (there shouldnt be a line number 261 anymore)

Xanaxus commented 2022年02月24日 02:22:40 +01:00 (Migrated from github.com)

The PR i guess; I just saw the changes in the file changed tab

Will try the new css now didn't see the changes properly

The PR i guess; I just saw the changes in the file changed tab Will try the new css now didn't see the changes properly

Xanaxus commented 2022年02月24日 04:10:52 +01:00 (Migrated from github.com)

The pref.css file for the side needs a small change on line 23;
--csd-margin-left: 92px; to --csd-margin-left: 140px;
And the window_contro.css line 25 needs a comment stating that This line handels the position of the window control button on the vertical plane as I needed it for my custom de theme

The pref.css file for the side needs a small change on line 23; `--csd-margin-left: 92px;` to `--csd-margin-left: 140px;` And the window_contro.css line 25 needs a comment stating that `This line handels the position of the window control button on the vertical plane` as I needed it for my custom de theme

macleod commented 2022年02月24日 18:26:03 +01:00

That's the beauty of the prefs.css file, the ability to easily change what each system and user needs (140px is far too much for me, but obviously not for you!)

That's the beauty of the prefs.css file, the ability to easily change what each system and user needs (140px is far too much for me, but obviously not for you!)

Xanaxus commented 2022年02月24日 19:15:26 +01:00 (Migrated from github.com)

I like it to be 50px but then restore button is overlapped by the prev pg button any idea how to fix it?

I like it to be 50px but then restore button is overlapped by the prev pg button any idea how to fix it?