cache_busting: Various enhancements #44

volpeon commented 2026年01月31日 12:35:01 +01:00 (Migrated from github.com)

This PR makes the following changes to the cache_busting plugin:

• Handle URLs with fragments. These are a common occurrence when working with SVG sprites.
• Add an option applyToCSS (off by default) which makes the plugin process all url() URLs encountered in CSS code. This allows web fonts to be cache busted, for instance.
• Clear the hash cache when Lume updates the website during development. This is necessary since otherwise files won't get renamed at all and the browser may display a broken or stale version of the website.

This PR makes the following changes to the cache_busting plugin: - Handle URLs with fragments. These are a common occurrence when working with SVG sprites. - Add an option `applyToCSS` (off by default) which makes the plugin process all `url()` URLs encountered in CSS code. This allows web fonts to be cache busted, for instance. - Clear the hash cache when Lume updates the website during development. This is necessary since otherwise files won't get renamed at all and the browser may display a broken or stale version of the website.

oscarotero commented 2026年01月31日 18:43:23 +01:00

Thank you!
Instead of the applyToCSS option, I think it's better to use a query parameter in the url, in order to make this feature opt-in in the same way that HTML does with attributes.
This also align better with how the inline plugin works.
What do you think?

Thank you! Instead of the `applyToCSS` option, I think it's better to use a query parameter in the url, in order to make this feature opt-in in the same way that HTML does with attributes. This also align better with [how the `inline` plugin works](https://lume.land/plugins/inline/#inline-in-css). What do you think?

volpeon commented 2026年01月31日 20:07:29 +01:00 (Migrated from github.com)

@oscarotero Oh, this solution is way better! I didn't like how my option was an all-or-nothing deal, but it didn't occur to me to use a query parameter. I'll update my code accordingly

@oscarotero Oh, this solution is way better! I didn't like how my option was an all-or-nothing deal, but it didn't occur to me to use a query parameter. I'll update my code accordingly

oscarotero commented 2026年02月01日 21:26:02 +01:00

thank you!

thank you!