2
0
Fork
You've already forked ds
0

fix: code selection not showed due to CSS bug #1

Merged
manueldeprada merged 1 commit from css-bug into main 2023年07月19日 20:51:58 +02:00
manueldeprada commented 2023年07月19日 19:53:33 +02:00 (Migrated from github.com)
Copy link

The code selection is not appearing when in dark mode, tested in Firefox and Edge. This problem was originally using the simple theme for blogs provided by Lume, which uses Prism. I am not sure if this affects highlightJS.

I investigated this issue and discovered that it was caused by a problem with the specification of the CSS color in ds/src/variables.css.

It turns out that when specifying percentages, hsl and hsla color definitions should use '0%' instead of just '0'. The use of '0' instead of '0px' and similar values is only allowed for lengths, as discussed here. However, I couldn't find any official documentation that specifically addresses this.

I also performed a quick regex search across all lumeland repositories, but I couldn't find this bug anywhere else.

Thank you for your excellent work and the support on Discord, @oscarotero ! Lume is fantastic, and I'm looking forward to seeing this fix in the next version of lume😄 🔥

The code selection is not appearing when in dark mode, tested in Firefox and Edge. This problem was originally using the simple theme for blogs provided by Lume, which uses Prism. I am not sure if this affects highlightJS. I investigated this issue and discovered that it was caused by a problem with the specification of the CSS color in ds/src/variables.css. It turns out that when specifying percentages, hsl and hsla color definitions should use '0%' instead of just '0'. The use of '0' instead of '0px' and similar values is only allowed for lengths, as discussed [here](https://stackoverflow.com/questions/31779146/any-bug-with-hsla0-0-0-0-becoming-hsla0-0-0-0-missing-percent-sig?noredirect=1&lq=1). However, I couldn't find any official documentation that specifically addresses this. I also performed a quick regex search across all lumeland repositories, but I couldn't find this bug anywhere else. Thank you for your excellent work and the support on Discord, @oscarotero ! Lume is fantastic, and I'm looking forward to seeing this fix in the next version of lume😄 :fire:

Excelent work, Thank you Manuel!!

Excelent work, Thank you Manuel!!
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lume/ds!1
Reference in a new issue
lume/ds
No description provided.
Delete branch "css-bug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?