fix: replace import with fetch to appease denodeploy #76

esroyo commented 2026年05月02日 00:07:01 +02:00 (Migrated from github.com)

On one hand, Deno Deploy's runtime is strictly forbidden from downloading new modules over the network while the app is actively running. On the other, It can't analyze a dynamic import with a variable string during the build and deployment phase. In the end, it does not download the JSON files into the deployment bundle, and we end-up with an error:

TypeError: Module not found
 at async setLocale (https://cdn.jsdelivr.net/gh/esroyo/cms@eaf17bd/static/common/locale.js:4:32)
 at async https://cdn.jsdelivr.net/gh/esroyo/cms@eaf17bd/core/routes/main.ts:80:7
 at async Router.#runHandler (https://deno.land/x/galo@v0.3.4/mod.ts:437:24)
 at async Router.#runRouter (https://deno.land/x/galo@v0.3.4/mod.ts:372:14)
 at async mapped (ext:deno_http/00_serve.ts:407:18) {
 code: "ERR_MODULE_NOT_FOUND"
}

@oscarotero would you mind replacing the beautiful locales dynamic import() with a nasty fetch? 😓

On one hand, Deno Deploy's runtime is strictly forbidden from downloading new modules over the network while the app is actively running. On the other, It can't analyze a dynamic import with a variable string during the build and deployment phase. In the end, it does not download the JSON files into the deployment bundle, and we end-up with an error: ``` TypeError: Module not found at async setLocale (https://cdn.jsdelivr.net/gh/esroyo/cms@eaf17bd/static/common/locale.js:4:32) at async https://cdn.jsdelivr.net/gh/esroyo/cms@eaf17bd/core/routes/main.ts:80:7 at async Router.#runHandler (https://deno.land/x/galo@v0.3.4/mod.ts:437:24) at async Router.#runRouter (https://deno.land/x/galo@v0.3.4/mod.ts:372:14) at async mapped (ext:deno_http/00_serve.ts:407:18) { code: "ERR_MODULE_NOT_FOUND" } ``` @oscarotero would you mind replacing the beautiful locales dynamic `import()` with a nasty `fetch`? :sweat:

oscarotero commented 2026年05月02日 10:48:33 +02:00

No problem.
Out of curiosity, are you using the new Deno deploy or the classic one?

No problem. Out of curiosity, are you using the new Deno deploy or the classic one?

esroyo commented 2026年05月02日 11:18:42 +02:00 (Migrated from github.com)

Thanks @oscarotero ❤️
I'm still using the classic one. I don't know if the new one will have similar limitations.

Thanks @oscarotero :heart: I'm still using the classic one. I don't know if the new one will have similar limitations.