librewolf/website
14
55
Fork
You've already forked website
39

Download button and instructions for Apple Silicon regarding notarization #91

Closed
jornane wants to merge 1 commit from jornane/librewolf-website:macos-arm64 into master
pull from: jornane/librewolf-website:macos-arm64
merge into: librewolf:master
librewolf:master
librewolf:dnf
librewolf:rel
librewolf:webgl
librewolf:changelog
librewolf:astro
First-time contributor
Copy link

Currently, the MacOS installation page lists two possible installation methods; Homebrew and Disk Image.

I don't use Homebrew, as I think the Homebrew project has little to no respect for the privacy of its users.
As such, I download LibreWolf as a disk image and install it that way.

Regarding the Disk Image, only a direct download button for macos-x86_64 is provided, even though LibreWolf is also built for macos-arm64. The latter is only available through the View all versions and release notes link.

When launching the macos-arm64 version, the user is presented with an error having to do with notarization. This is explained very well in the FAQ and the linked issue, but it's not explained on the installation page.

This pull request adds a download button for macos-arm64 disk image, and adds instructions to both the installation page and the FAQ on how to work around the MacOS error resulting from downloading a non-notarized file, by using the xattr -d command to remove the quarantine flag.

Please note that I did not try to build the page, as I don't have NodeJS installed here. As such, this PR might introduce build errors.

Currently, the MacOS installation page lists two possible installation methods; Homebrew and Disk Image. I don't use Homebrew, as I think the Homebrew project has little to no respect for the privacy of its users. As such, I download LibreWolf as a disk image and install it that way. Regarding the Disk Image, only a direct download button for **macos-x86_64** is provided, even though LibreWolf is also built for **macos-arm64**. The latter is only available through the *View all versions and release notes* link. When launching the **macos-arm64** version, the user is presented with an error having to do with notarization. This is explained very well in the FAQ and the linked issue, but it's not explained on the installation page. This pull request adds a download button for **macos-arm64** disk image, and adds instructions to both the installation page and the FAQ on how to work around the MacOS error resulting from downloading a non-notarized file, by using the `xattr -d` command to remove the quarantine flag. Please note that I did not try to build the page, as I don't have NodeJS installed here. As such, this PR might introduce build errors.

Yes, this looks like a good PR to me, I'm not in charge of the website, but I can attempt a merge in a couple of days

Yes, this looks like a good PR to me, I'm not in charge of the website, but I can attempt a merge in a couple of days
maltejur left a comment
Copy link

Ugh, sorry that this PR got lost until now.

Ugh, sorry that this PR got lost until now.
@ -12,3 +12,3 @@
export const getStaticProps = getStaticDownloadButtonProps([
getGitlabDownloadProp("macosDownload", "44042130", "macos-x86_64-package.dmg")
getGitlabDownloadProp("macosDownload", "44042130", "macos-x86_64-package.dmg"),
Owner
Copy link

Can you just remove the old entry for macos-x86_64? Otherwise, this code will not work, or you will need to add a second button with a different id than macosDownload, which wouldn't look that great imo.

Can you just remove the old entry for macos-x86_64? Otherwise, this code will not work, or you will need to add a second button with a different id than `macosDownload`, which wouldn't look that great imo.
jornane marked this conversation as resolved
Author
First-time contributor
Copy link

Ah the first argument has to be unique?
Intel Macs are still in circulation, so I'm not sure it would make sense to remove the button.
Can we make two different id's instead, such as macosIntelDownload and macosArmDownload?

Ah the first argument has to be unique? Intel Macs are still in circulation, so I'm not sure it would make sense to remove the button. Can we make two different id's instead, such as `macosIntelDownload` and `macosArmDownload`?

@jornane wrote in #91 (comment):

Ah the first argument has to be unique? Intel Macs are still in circulation, so I'm not sure it would make sense to remove the button. Can we make two different id's instead, such as macosIntelDownload and macosArmDownload?

Sure, you would just need to add a second <GitlabDownloadButton id="..." /> down below with the appropriate ID. But IMO, only updating the existing button to use offer the ARM version would also be adequate, as there is a link next to the button for more downloads for that version.

@jornane wrote in https://codeberg.org/librewolf/website/pulls/91#issuecomment-2927476: > Ah the first argument has to be unique? Intel Macs are still in circulation, so I'm not sure it would make sense to remove the button. Can we make two different id's instead, such as `macosIntelDownload` and `macosArmDownload`? Sure, you would just need to add a second `<GitlabDownloadButton id="..." />` down below with the appropriate ID. But IMO, only updating the existing button to use offer the ARM version would also be adequate, as there is a link next to the button for more downloads for that version.
Author
First-time contributor
Copy link

I replaced the <GitlabDownloadButton id="..." /> with two buttons with the corresponding IDs. @maltejur

I replaced the `<GitlabDownloadButton id="..." />` with two buttons with the corresponding IDs. @maltejur
Author
First-time contributor
Copy link

It seems that this change is not wanted, and the immediate problem has been solved in 2b7314aadc and #116, thanks @any1here and @maltejur!

I'm no longer interested in trying to get this merged after more than a year, so I'll be closing this.

It seems that this change is not wanted, and the immediate problem has been solved in 2b7314aadce5476ae0af71d7cf32ed7cec20f749 and [#116](https://codeberg.org/librewolf/website/pulls/116), thanks @any1here and @maltejur! I'm no longer interested in trying to get this merged after more than a year, so I'll be closing this.
jornane closed this pull request 2025年12月27日 23:53:09 +01:00

Sorry @jornane this PR got delayed so much :c
any1here recently added the correct download button to the website, and malte is currently working on getting a proper signature for the Apple and Windows releases soon.

This should address all the mentioned issues, correct?
If you still have anything you'd like to change or improve, feel free to reach out.
I’m happy to help and maybe push things through a little quicker than this time :)

In any case, thanks a lot for your effort! <3

Sorry @jornane this PR got delayed so much :c any1here recently added the correct download button to the website, and malte is currently working on getting a proper signature for the Apple and Windows releases *soon*. This should address all the mentioned issues, correct? If you still have anything you'd like to change or improve, feel free to reach out. I’m happy to help and maybe push things through a little quicker than this time :) In any case, thanks a lot for your effort! <3

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
librewolf/website!91
Reference in a new issue
librewolf/website
No description provided.
Delete branch "jornane/librewolf-website:macos-arm64"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?