Adding repository using DNF command #124

For reference, see the official Fedora documentation: https://docs.fedoraproject.org/en-US/quick-docs/adding-or-removing-software-repositories-in-fedora/#_adding_repositories

This PR closes librewolf/issues#2346.

Have you tested this?

What criteria are important to you when it comes to testing?

Does running sudo dnf config-manager addrepo --from-repofile=https://repo.librewolf.net/librewolf.repo work now?

And somehow, the prompt to import your key appears twice. I don't understand that yet.

Once during the step sudo dnf config-manager addrepo --from-repofile=https://repo.librewolf.net/librewolf.repo
and then again during the step sudo dnf install librewolf.

Do you know anything about it? Or could it be relevant?

@eIKpaSrnMoKI wrote in #124 (comment):

And somehow, the prompt to import your key appears twice. I don't understand that yet. Do you know anything about it? Or could it be relevant?

I was able to reproduce the double prompt. This should only double prompt when you add the repo for the first time.
If you try to install librewolf after that again, it should only prompt you once.

I was able to reproduce the double prompt. This should only double prompt when you add the repo for the first time.

Do you have an explanation why the double prompt appears when you first do it?

Have you also tested the installation path, and would you say that the PR is ready to go?

I'm just wondering whether it's important to start both installation steps with sudo. If I stay in the terminal, the first sudo command remains active for a certain period of time.

@eIKpaSrnMoKI wrote in #124 (comment):

I was able to reproduce the double prompt. This should only double prompt when you add the repo for the first time.

Do you have an explanation why the double prompt appears when you first do it?

Have you also tested the installation path, and would you say that the PR is ready to go?

I would assume that adding the repo triggers the first prompt.

@eIKpaSrnMoKI wrote in #124 (comment):

I'm just wondering whether it's important to start both installation steps with sudo. If I stay in the terminal, the first sudo command remains active for a certain period of time.

You still need to add sudo in front both the commands. The other command might just not prompt you for the password if you do it before the timeout happens.

@any1here wrote in #124 (comment):

Have you tested this?

With Fedora Workstation, yes.
And not with Fedora Atomic Desktops.
Perhaps someone looking at this PR could try it out?

@eIKpaSrnMoKI wrote in #124 (comment):

@any1here wrote in #124 (comment):

Have you tested this?

With Fedora Workstation, yes. And not with Fedora Atomic Desktops. Perhaps someone looking at this PR could try it out?

It seems to work on atomic too. You can remove the WIP if you are ready for it to be merged.

Thank you for the PR!

Thank you for supporting me!

It seems to work on atomic too.

Is the command dnf config-manager addrepo --from-repofile=https://repo.librewolf.net/librewolf.repo also required for an installation on an Atomic Fedora desktop?

@eIKpaSrnMoKI wrote in #124 (comment):

It seems to work on atomic too.

Is the command dnf config-manager addrepo --from-repofile=https://repo.librewolf.net/librewolf.repo also required for an installation on an Atomic Fedora desktop?

Yes