librewolf/source
55
1.2k
Fork
You've already forked source
90

Replace illustrations on neterror pages #172

Merged
maltejur merged 1 commit from neterror into main 2026年04月28日 12:05:22 +02:00

This removes the Kit branding from the network error pages. It is replaced with an orange exclamation mark on security error pages and nothing on other error pages, which aligns roughly with how these pages looked before security.certerrors.felt-privacy-v1.

I think there is certainly a potential for us to redesign this page a bit more to surface more information again from the advanced section, but that was out of scope for getting the branding fixed first.

Closes librewolf/issues#2970

Screenshot_20260427_235217

image

This removes the Kit branding from the network error pages. It is replaced with an orange exclamation mark on security error pages and nothing on other error pages, which aligns roughly with how these pages looked before `security.certerrors.felt-privacy-v1`. I think there is certainly a potential for us to redesign this page a bit more to surface more information again from the advanced section, but that was out of scope for getting the branding fixed first. Closes librewolf/issues#2970 ![Screenshot_20260427_235217](/attachments/db7afcb5-dc91-4eac-966b-4a480cbbbc09) ![image](/attachments/30fa7c4d-5cf0-4cd3-bb25-1943b769909b)
Replace illustrations on neterror pages
Some checks failed
Create Test Builds / detect-version (pull_request) Successful in 9s
Create Test Builds / test-windows (pull_request) Has been skipped
Create Test Builds / test-macos (pull_request) Has been skipped
Create Test Builds / test-linux (pull_request) Has been cancelled
badcc33921
maltejur force-pushed neterror from badcc33921
Some checks failed
Create Test Builds / detect-version (pull_request) Successful in 9s
Create Test Builds / test-windows (pull_request) Has been skipped
Create Test Builds / test-macos (pull_request) Has been skipped
Create Test Builds / test-linux (pull_request) Has been cancelled
to 1a8a251c40
Some checks failed
Create Test Builds / detect-version (pull_request) Successful in 7s
Create Test Builds / test-windows (pull_request) Has been skipped
Create Test Builds / test-macos (pull_request) Has been skipped
Create Test Builds / test-linux (pull_request) Failing after 1m8s
2026年04月28日 00:07:00 +02:00 Compare 
diff --git a/toolkit/themes/shared/desktop-jar.inc.mn b/toolkit/themes/shared/desktop-jar.inc.mn
index c8e6055..2f38422 100644
--- a/toolkit/themes/shared/desktop-jar.inc.mn
+++ b/toolkit/themes/shared/desktop-jar.inc.mn
@@ -139,6 +139,7 @@
 skin/classic/global/illustrations/shield-check.svg (../../shared/illustrations/shield-check.svg)
 skin/classic/global/illustrations/shield-alert.svg (../../shared/illustrations/shield-alert.svg)
 skin/classic/global/illustrations/no-connection.svg (../../shared/illustrations/no-connection.svg)
+ skin/classic/global/illustrations/warning.svg (../../shared/illustrations/warning.svg)
 skin/classic/global/media/picture-in-picture-open.svg (../../shared/media/picture-in-picture-open.svg)
 skin/classic/global/media/picture-in-picture-closed.svg (../../shared/media/picture-in-picture-closed.svg)
 skin/classic/global/icons/minus.svg (../../shared/icons/minus.svg)

since it seems like it doesn't work with nightly

Wasn't sure if you want me to just edit your PR

``` diff --git a/toolkit/themes/shared/desktop-jar.inc.mn b/toolkit/themes/shared/desktop-jar.inc.mn index c8e6055..2f38422 100644 --- a/toolkit/themes/shared/desktop-jar.inc.mn +++ b/toolkit/themes/shared/desktop-jar.inc.mn @@ -139,6 +139,7 @@ skin/classic/global/illustrations/shield-check.svg (../../shared/illustrations/shield-check.svg) skin/classic/global/illustrations/shield-alert.svg (../../shared/illustrations/shield-alert.svg) skin/classic/global/illustrations/no-connection.svg (../../shared/illustrations/no-connection.svg) + skin/classic/global/illustrations/warning.svg (../../shared/illustrations/warning.svg) skin/classic/global/media/picture-in-picture-open.svg (../../shared/media/picture-in-picture-open.svg) skin/classic/global/media/picture-in-picture-closed.svg (../../shared/media/picture-in-picture-closed.svg) skin/classic/global/icons/minus.svg (../../shared/icons/minus.svg) ``` since it seems like it doesn't work with nightly Wasn't sure if you want me to just edit your PR
maltejur force-pushed neterror from 1a8a251c40
Some checks failed
Create Test Builds / detect-version (pull_request) Successful in 7s
Create Test Builds / test-windows (pull_request) Has been skipped
Create Test Builds / test-macos (pull_request) Has been skipped
Create Test Builds / test-linux (pull_request) Failing after 1m8s
to 07c63c3be5
All checks were successful
Create Test Builds / detect-version (pull_request) Successful in 6s
Create Test Builds / test-macos (pull_request) Has been skipped
Create Test Builds / test-windows (pull_request) Has been skipped
Create Test Builds / test-linux (pull_request) Successful in 32m0s
Create Test Builds / detect-version (push) Successful in 6s
Create Test Builds / test-macos (push) Has been skipped
Create Test Builds / test-windows (push) Has been skipped
Create Test Builds / test-linux (push) Successful in 31m41s
2026年04月28日 09:34:36 +02:00 Compare
Author
Owner
Copy link

@any1here wrote in #172 (comment):

diff --git a/toolkit/themes/shared/desktop-jar.inc.mn b/toolkit/themes/shared/desktop-jar.inc.mn
index c8e6055..2f38422 100644
--- a/toolkit/themes/shared/desktop-jar.inc.mn
+++ b/toolkit/themes/shared/desktop-jar.inc.mn
@@ -139,6 +139,7 @@
 skin/classic/global/illustrations/shield-check.svg (../../shared/illustrations/shield-check.svg)
 skin/classic/global/illustrations/shield-alert.svg (../../shared/illustrations/shield-alert.svg)
 skin/classic/global/illustrations/no-connection.svg (../../shared/illustrations/no-connection.svg)
+ skin/classic/global/illustrations/warning.svg (../../shared/illustrations/warning.svg)
 skin/classic/global/media/picture-in-picture-open.svg (../../shared/media/picture-in-picture-open.svg)
 skin/classic/global/media/picture-in-picture-closed.svg (../../shared/media/picture-in-picture-closed.svg)
 skin/classic/global/icons/minus.svg (../../shared/icons/minus.svg)

since it seems like it doesn't work with nightly

Wasn't sure if you want me to just edit your PR

Thanks, updated. But yeah, you can also just edit my PRs, no problem.

@any1here wrote in https://codeberg.org/librewolf/source/pulls/172#issuecomment-13912580: > ```text > diff --git a/toolkit/themes/shared/desktop-jar.inc.mn b/toolkit/themes/shared/desktop-jar.inc.mn > index c8e6055..2f38422 100644 > --- a/toolkit/themes/shared/desktop-jar.inc.mn > +++ b/toolkit/themes/shared/desktop-jar.inc.mn > @@ -139,6 +139,7 @@ > skin/classic/global/illustrations/shield-check.svg (../../shared/illustrations/shield-check.svg) > skin/classic/global/illustrations/shield-alert.svg (../../shared/illustrations/shield-alert.svg) > skin/classic/global/illustrations/no-connection.svg (../../shared/illustrations/no-connection.svg) > + skin/classic/global/illustrations/warning.svg (../../shared/illustrations/warning.svg) > skin/classic/global/media/picture-in-picture-open.svg (../../shared/media/picture-in-picture-open.svg) > skin/classic/global/media/picture-in-picture-closed.svg (../../shared/media/picture-in-picture-closed.svg) > skin/classic/global/icons/minus.svg (../../shared/icons/minus.svg) > ``` > > since it seems like it doesn't work with nightly > > Wasn't sure if you want me to just edit your PR Thanks, updated. But yeah, you can also just edit my PRs, no problem.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
librewolf/source!172
Reference in a new issue
librewolf/source
No description provided.
Delete branch "neterror"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?