librewolf/settings
14
22
Fork
You've already forked settings
26

cfg: change etp from pref to defaultPref #83

Open
brian6932 wants to merge 1 commit from brian6932/settings:cfg/change-etp-from-pref-to-defaultPref into master
pull from: brian6932/settings:cfg/change-etp-from-pref-to-defaultPref
merge into: librewolf:master
librewolf:master
librewolf:getbrowserinfo
librewolf:rs-blocker
librewolf:dom_push
librewolf:set_to_version_8_4
librewolf:newtabpage_weatherinfo
First-time contributor
Copy link

This just doesn't make sense, if someone sets it to custom it'll revert on launch. I'm confused by the comment, why doesn't/wouldn't it stick? Do the child prefs not apply when using defaultPref? It's pretty annoying for debugging to have this happen.

This just doesn't make sense, if someone sets it to `custom` it'll revert on launch. I'm confused by the comment, why doesn't/wouldn't it stick? Do the child prefs not apply when using `defaultPref`? It's pretty annoying for debugging to have this happen.

We "soft-lock" the ETP pref to prevent users from inadvertently disabling partitioning by setting the ETP pref to custom. This FAQ entry goes in a bit of detail on that.

It's pretty annoying for debugging to have this happen.

What exactly are you trying to achieve? If you want to check if ETP is causing a specific breakage, you can just use the shield icon in the address bar.

We "soft-lock" the ETP pref to prevent users from inadvertently disabling partitioning by setting the ETP pref to custom. [This](https://librewolf.net/docs/faq/#what-is-enhanced-tracking-protection) FAQ entry goes in a bit of detail on that. > It's pretty annoying for debugging to have this happen. What exactly are you trying to achieve? If you want to check if ETP is causing a specific breakage, you can just use the shield icon in the address bar.

Last time I checkded the pref didn't apply when using defaultPref.

Last time I checkded the pref didn't apply when using `defaultPref`.
Author
First-time contributor
Copy link

What exactly are you trying to achieve?

Sometimes certain parts of etp's blocking can break stuff, and I'll disable those (usually temporarily), while keeping the rest of etp active. This also lets you narrow down the cause, and then report the issues to bugzilla.

> What exactly are you trying to achieve? Sometimes certain parts of etp's blocking can break stuff, and I'll disable those (usually temporarily), while keeping the rest of etp active. This also lets you narrow down the cause, and then report the issues to bugzilla.
This pull request has changes conflicting with the target branch.
  • librewolf.cfg
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u cfg/change-etp-from-pref-to-defaultPref:brian6932-cfg/change-etp-from-pref-to-defaultPref
git switch brian6932-cfg/change-etp-from-pref-to-defaultPref

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff brian6932-cfg/change-etp-from-pref-to-defaultPref
git switch brian6932-cfg/change-etp-from-pref-to-defaultPref
git rebase master
git switch master
git merge --ff-only brian6932-cfg/change-etp-from-pref-to-defaultPref
git switch brian6932-cfg/change-etp-from-pref-to-defaultPref
git rebase master
git switch master
git merge --no-ff brian6932-cfg/change-etp-from-pref-to-defaultPref
git switch master
git merge --squash brian6932-cfg/change-etp-from-pref-to-defaultPref
git switch master
git merge --ff-only brian6932-cfg/change-etp-from-pref-to-defaultPref
git switch master
git merge brian6932-cfg/change-etp-from-pref-to-defaultPref
git push origin master
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
librewolf/settings!83
Reference in a new issue
librewolf/settings
No description provided.
Delete branch "brian6932/settings:cfg/change-etp-from-pref-to-defaultPref"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?