librewolf/settings
10
29
Fork
You've already forked settings
31

Revert recent safe browsing pref changes #82

Merged
ohfp merged 1 commit from push-utkvzuuyytkw into master 2025年04月05日 22:49:22 +02:00

This reverts #76 to fix librewolf/issues#2374.

As far as I can tell, in the original issue librewolf/issues#1879, there were no real reasons stated to introduce these pref changes, beside "avoid confusion for new users who want to trust you as you say" (?). These changes have broken ETP blocking, and have not considered that we have an option in the settings for enabling safe browsing again. Currently, that checkbox is also not fully working, as it is not flipping all the needed prefs to enable safe browsing again.

Thus, for now, I think we should just revert the changes from #76. As a follow-up, we could also consider reducing the set of safe browsing prefs even further, as suggested in librewolf/issues#2374 (comment). But that would require updating the pref pane again, so I just want to revert the breaking changes as a first step.

This reverts https://codeberg.org/librewolf/settings/pulls/76 to fix librewolf/issues#2374. As far as I can tell, in the original issue https://codeberg.org/librewolf/issues/issues/1879, there were no real reasons stated to introduce these pref changes, beside "avoid confusion for new users who want to trust you as you say" (?). These changes have broken ETP blocking, and have not considered that we have an option in the settings for enabling safe browsing again. Currently, that checkbox is also not fully working, as it is not flipping all the needed prefs to enable safe browsing again. Thus, for now, I think we should just revert the changes from https://codeberg.org/librewolf/settings/pulls/76. As a follow-up, we could also consider reducing the set of safe browsing prefs even further, as suggested in https://codeberg.org/librewolf/issues/issues/2374#issuecomment-3097592. But that would require updating the pref pane again, so I just want to revert the breaking changes as a first step.
ohfp deleted branch push-utkvzuuyytkw 2025年04月05日 22:49:26 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
librewolf/settings!82
Reference in a new issue
librewolf/settings
No description provided.
Delete branch "push-utkvzuuyytkw"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?