librewolf/gentoo
15
36
Fork
You've already forked gentoo
7

ebuild fixes, add pkgcheck ci workflow #70

Merged
TheGreatMcPain merged 3 commits from nvraxn/librewolf-overlay:master into master 2025年07月03日 19:21:00 +02:00
Contributor
Copy link

Please see commits descriptions for additional details.

Please see commits descriptions for additional details.
Fixes pkgcheck lint BadDefaultUseFlags[1]. Flags in IUSE are off by
default unless prefixed with a plus symbol, so dropping the '-' is
equivalent except for funky USE_ORDER. From the Gentoo devmanual[2]:
> Important: Adding - before a flag in IUSE is pretty much useless, as
> it will neither override the user configuration (make.conf) nor the
> profile default (make.defaults and package.use). See make.conf(5) for
> details on USE-ordering in Portage.
[1] https://pkgcore.github.io/pkgcheck/api/pkgcheck.checks.metadata.html
[2] https://devmanual.gentoo.org/general-concepts/use-flags/index.html#iuse-defaults
Signed-off-by: Rahul Sandhu <nvraxn@gmail.com>
When IUSE=test exists, FEATURES=test should be restricted to builds
where IUSE=test exists only (as IUSE=test is a prerequisite for tests
to succeed here). Fixes pkgcheck lint MissingTestRestrict[1].
[1] https://pkgcore.github.io/pkgcheck/api/pkgcheck.checks.metadata.html#pkgcheck.checks.metadata.MissingTestRestrict
Signed-off-by: Rahul Sandhu <nvraxn@gmail.com>
Signed-off-by: Rahul Sandhu <nvraxn@gmail.com>

Looks good. Thanks!

Looks good. Thanks!
Author
Contributor
Copy link

No worries. For CI to actually run, you might need to add the repository here https://ci.codeberg.org/repos and if you haven't already, request CI access for the librewolf org here: https://codeberg.org/Codeberg-e.V./requests/issues/new?template=ISSUE_TEMPLATE%2fWoodpecker-CI.yaml, see https://docs.codeberg.org/ci/ for more info. Thanks for merging!

No worries. For CI to actually run, you might need to add the repository here https://ci.codeberg.org/repos and if you haven't already, request CI access for the librewolf org here: https://codeberg.org/Codeberg-e.V./requests/issues/new?template=ISSUE_TEMPLATE%2fWoodpecker-CI.yaml, see https://docs.codeberg.org/ci/ for more info. Thanks for merging!

Looks like a few people in the org already have access. I currently don't, but I'll look into getting access.

Part of me feels like using CI for pkgcheck is kind of unnecessary considering I mostly just copy www-client/firefox and add tweak it a bit for librewolf. If pkgcheck complains about www-client/firefox it'll probably complain about www-client/librewolf too.

Looks like [a few people in the org already have access.](https://codeberg.org/Codeberg-e.V./requests/issues/39) I currently don't, but I'll look into getting access. Part of me feels like using CI for `pkgcheck` is kind of unnecessary considering I mostly just copy `www-client/firefox` and add tweak it a bit for librewolf. If `pkgcheck` complains about `www-client/firefox` it'll probably complain about `www-client/librewolf` too.

Yeah, looks like LibreWolf isn't planning to use Woodpecker.

Yeah, looks like [LibreWolf isn't planning to use Woodpecker.](https://codeberg.org/librewolf/issues/issues/1576)
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
librewolf/gentoo!70
Reference in a new issue
librewolf/gentoo
No description provided.
Delete branch "nvraxn/librewolf-overlay:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?