librewolf/bsys6
21
49
Fork
You've already forked bsys6
14

Integrate with the Debian alternatives system #18

Closed
dimkr wants to merge 1 commit from dimkr/bsys6:master into master
pull from: dimkr/bsys6:master
merge into: librewolf:master
librewolf:master
librewolf:pgo
librewolf:clang
librewolf:way
librewolf:widl
librewolf:sign
librewolf:epsilon-build
librewolf:macos
librewolf:push-tqrkuuulmolt
librewolf:fxa
librewolf:tmp-docker-fix
librewolf:signing
librewolf:auto_winupdater
librewolf:woodpecker
librewolf:tests
librewolf:fbsd
librewolf:installer_fix
librewolf:work
First-time contributor
Copy link

{x,gnome}-www-browser points to LibreWolf if no other browser is installed or if installed alongside lower priority options like Debian's firefox-esr.

200 is the priority used by Chrome and Edge (higher than Debian's firefox-esr, firefox and chromium), so it's "fair" to use it for LibreWolf too.

Fixes librewolf/issues#108.

(I haven't tested this PR.)

Closes librewolf/issues#2498

{x,gnome}-www-browser points to LibreWolf if no other browser is installed or if installed alongside lower priority options like Debian's firefox-esr. 200 is the priority used by Chrome and Edge (higher than Debian's firefox-esr, firefox and chromium), so it's "fair" to use it for LibreWolf too. Fixes librewolf/issues#108. (I haven't tested this PR.) Closes librewolf/issues#2498

Thanks for this PR, it isn't forgotten, but I still haven't found the time to properly test it.

Thanks for this PR, it isn't forgotten, but I still haven't found the time to properly test it.
First-time contributor
Copy link

This commit is lacking appropriate tests to prevent update-alternatives from being called at the wrong time.

The postinst script's update-alternatives commands need to be wrapped as follows:

if [ "1ドル" = configure ] || [ "1ドル" = abort-upgrade ] || [ "1ドル" = abort-remove ]; then
 ...
fi

The prerm script's update-alternatives commands need to be wrapped as follows:

if [ "1ドル" = remove ] || [ "1ドル" = deconfigure ]; then
 ...
fi

(This is exactly what Debian's firefox package does.)

Also, the first three lines of each can be collapsed to #! /bin/sh -e, and it may be better to point at /usr/bin/librewolf.

This commit is lacking appropriate tests to prevent `update-alternatives` from being called at the wrong time. The `postinst` script's `update-alternatives` commands need to be wrapped as follows: ```sh if [ "1ドル" = configure ] || [ "1ドル" = abort-upgrade ] || [ "1ドル" = abort-remove ]; then ... fi ``` The `prerm` script's `update-alternatives` commands need to be wrapped as follows: ```sh if [ "1ドル" = remove ] || [ "1ドル" = deconfigure ]; then ... fi ``` (This is exactly what Debian's `firefox` package does.) Also, the first three lines of each can be collapsed to `#! /bin/sh -e`, and it may be better to point at `/usr/bin/librewolf`.
Author
First-time contributor
Copy link

@dsalt Thanks, I aligned with https://sources.debian.org/src/firefox-esr/128.12.0esr-1/debian/browser.postinst.in/ and https://sources.debian.org/src/firefox-esr/128.12.0esr-1/debian/browser.prerm.in/

@dsalt Thanks, I aligned with https://sources.debian.org/src/firefox-esr/128.12.0esr-1/debian/browser.postinst.in/ and https://sources.debian.org/src/firefox-esr/128.12.0esr-1/debian/browser.prerm.in/

This was added in the move to fpm.

This was added in the [move to fpm](https://codeberg.org/librewolf/bsys6/pulls/26).
any1here closed this pull request 2026年01月14日 14:39:32 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
librewolf/bsys6!18
Reference in a new issue
librewolf/bsys6
No description provided.
Delete branch "dimkr/bsys6:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?