librewolf/arch
13
63
Fork
You've already forked arch
16

Use a fixed-place pkgver #16

Merged
ohfp merged 1 commit from marbens/librewolf-arch:fixed-place-versioning into master 2025年03月06日 07:55:03 +01:00
Contributor
Copy link

Use a pkgver-scheme with a fixed amount of places (4 in this case).

Because 136.0-2 released, and not 136.0.1-1 or 137.0-1, bumping to
136.0-2 of this new versioning scheme makes the old versions using the
old versioning appear newer than the new versions using the new
versioning scheme, so we need to bump epoch to 1.

Updating this package to 136.0-2 is out of scope for this branch.

This fixes the problem mentioned in the AUR comment
made by petris.

Also credit goes to petris on the AUR for making the base for the shell
expansions for _firefoxver and _librewolfver.

The binary side (librewolf-bin) is good enough to build and make this pull request (I made this pull request with a build from it).

Use a pkgver-scheme with a fixed amount of places (4 in this case). Because 136.0-2 released, and not 136.0.1-1 or 137.0-1, bumping to 136.0-2 of this new versioning scheme makes the old versions using the old versioning appear newer than the new versions using the new versioning scheme, so we need to bump epoch to 1. Updating this package to 136.0-2 is out of scope for this branch. This fixes the problem mentioned in the [AUR comment](https://aur.archlinux.org/packages/librewolf-bin#comment-1014287) made by petris. Also credit goes to petris on the AUR for making the base for the shell expansions for _firefoxver and _librewolfver. The binary side (`librewolf-bin`) is good enough to build and make this pull request (I made this pull request with a build from it).
@ -30,3 +33,1 @@
_base_url=https://gitlab.com/api/v4/projects/${_project_id}/packages/generic/${pkgname//-bin/""}/${pkgver//_/-}
_uploadpath_aarch64=${_base_url}/${pkgname//-bin/""}-${pkgver//_/-}-linux-arm64-package.tar.xz
_uploadpath_x86_64=${_base_url}/${pkgname//-bin/""}-${pkgver//_/-}-linux-x86_64-package.tar.xz
_base_url=https://gitlab.com/api/v4/projects/${_project_id}/packages/generic/${pkgname//-bin/""}/$_firefoxver-$_librewolfver
Author
Contributor
Copy link

If the firefox patch number gets set here, then this excludes it, so this is wrong.

If the firefox patch number gets set here, then this excludes it, so this is wrong.
Author
Contributor
Copy link

I've remade it so it tolerates this.

I've remade it so it tolerates this.
marbens marked this conversation as resolved
marbens force-pushed fixed-place-versioning from 469320f717 to e502952bc3 2025年03月06日 04:50:16 +01:00 Compare
Owner
Copy link

Thanks very much for already picking this up from the comments! That saves me from having to think too much this early in the day ;)

I'll go ahead and merge it already, to get the 136.0-2 release out asap with it.

Thanks very much for already picking this up from the comments! That saves me from having to think too much this early in the day ;) I'll go ahead and merge it already, to get the 136.0-2 release out asap with it.
marbens changed title from (削除) (build for source package in progress) Use a fixed-place pkgver (削除ここまで) to Use a fixed-place pkgver 2025年03月06日 09:11:08 +01:00
Author
Contributor
Copy link

The build for the source package (librewolf) has completed now, and works, but this has already been merged.

The build for the source package (`librewolf`) has completed now, and works, but this has already been merged.
marbens deleted branch fixed-place-versioning 2025年03月06日 09:20:04 +01:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
librewolf/arch!16
Reference in a new issue
librewolf/arch
No description provided.
Delete branch "marbens/librewolf-arch:fixed-place-versioning"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?