11
43
Fork
You've already forked base
6

test: add tests for updateUser #262

Merged
PW merged 1 commit from Ryuno-Ki/base:fixing-express-mongoose into dev 2024年04月09日 14:42:16 +02:00

I wasn't able to hit all possible cases here, because some appear to be
impossible to meet. Like, I have found an user in the session by
validating against the database but that very same record is gone in the
next second? Maybe the middleware would need some detangling to simulate
this but at that point I'm not sure whether it would be worth the
effort. Might make sense to investigate what led to the current
implementation instead.

Signed-off-by: André Jaenisch andre.jaenisch@posteo.de

I wasn't able to hit all possible cases here, because some appear to be impossible to meet. Like, I have found an user in the session by validating against the database but that very same record is gone in the next second? Maybe the middleware would need some detangling to simulate this but at that point I'm not sure whether it would be worth the effort. Might make sense to investigate what led to the current implementation instead. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
test: add tests for updateUser
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending
3907422065
 
I wasn't able to hit all possible cases here, because some appear to be
impossible to meet. Like, I have found an user in the session by
validating against the database but that very same record is gone in the
next second? Maybe the middleware would need some detangling to simulate
this but at that point I'm not sure whether it would be worth the
effort. Might make sense to investigate what led to the current
implementation instead.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Ryuno-Ki deleted branch fixing-express-mongoose 2024年04月10日 09:40:05 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
Kind: Enhancement
improvement of a feature
Kind: Feature
Something totally new
Kind: Interesting for Wiki
to be saved in the wiki
Kind: invalid
Something is wrong
Kind: Question
More information is needed
Kind: Security
Relevant for security
Kind:bug
Something is not working
Priority: High
Priority: Low
Priority: Medium
Status: Contribution welcome
Contributions are very welcome, get started here
Status: Duplicate
This issue or pull request already exists
Status: External problem
There is an external problem
Status: Help wanted
Need some help
Status: In progress
Someone's working on it
Status: In review
we're testing a possible solution
Status: next release
All tested and ready for the next release
Status: Starters
This is a good task to start helping lerntools
Status: Tests neededd
Need some tests for locating the problem
Status: won't fix
This won't be fixed
vue3
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lerntools/base!262
Reference in a new issue
lerntools/base
No description provided.
Delete branch "Ryuno-Ki/base:fixing-express-mongoose"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?