fix light/dark mode #2

jothi-prasath commented 2023年07月09日 13:17:27 +02:00

i defaults to dark mode when page loads instead of light mode which avoids wired splash of white colors at page load

i defaults to dark mode when page loads instead of light mode which avoids wired splash of white colors at page load

langurmonkey commented 2023年07月10日 08:26:34 +02:00

I don't really see the issue. There is no splash of white once the site (and the js) is cached. Changing the default theme to dark does the opposite if the user prefers light mode, i.e., they will get a splash of dark (the first time only).

I don't really see the issue. There is no splash of white once the site (and the js) is cached. Changing the default theme to dark does the opposite if the user prefers light mode, i.e., they will get a splash of dark (the first time only).

jothi-prasath commented 2023年07月10日 08:39:16 +02:00

my perspective on the issue is if a user first time enters into the site obviously they are using dark mode by default here the splash of white is a thing because there is no cache so the white splash is noticeable. And if the user wants to switch to light mode, already .js files are cached so the splash of dark is doesn't seem to be noticed.

my perspective on the issue is if a user first time enters into the site obviously they are using dark mode by default here the splash of white is a thing because there is no cache so the white splash is noticeable. And if the user wants to switch to light mode, already .js files are cached so the splash of dark is doesn't seem to be noticed.

langurmonkey commented 2023年07月10日 10:34:46 +02:00

Well, the default theme is light, not dark. Anyway, I have fixed the root cause of the issue. That is, separating the javascript code that applies the theme from the site-bundle.js and loading it at the top of the body. Flickering should be gone now. See b797654c.

Well, the default theme is light, not dark. Anyway, I have fixed the root cause of the issue. That is, separating the javascript code that applies the theme from the site-bundle.js and loading it at the top of the body. Flickering should be gone now. See b797654c.