kramo/hyperplane
Archived
1
8
Fork
You've already forked hyperplane
0

Fix inconsistent grid item colors #6

Merged
rdbende merged 4 commits from item-color-fix into main 2023年12月18日 12:59:28 +01:00
rdbende commented 2023年12月18日 11:43:09 +01:00 (Migrated from github.com)
Copy link

The CSS classes need to be reset before adding new ones, otherwise the item's colors will be quite random.

The CSS classes need to be reset before adding new ones, otherwise the item's colors will be quite random.
kra-mo (Migrated from github.com) reviewed 2023年12月18日 12:22:22 +01:00
kra-mo (Migrated from github.com) commented 2023年12月18日 12:22:22 +01:00

Is there a reason to use else instead of return?

Is there a reason to use else instead of return?
kra-mo (Migrated from github.com) reviewed 2023年12月18日 12:25:09 +01:00
kra-mo (Migrated from github.com) commented 2023年12月18日 12:25:08 +01:00

These should probably be done in unbind(). bind() should only run again after unbind() has been run.

These should probably be done in `unbind()`. `bind()` should only run again after `unbind()` has been run.
kra-mo commented 2023年12月18日 12:43:08 +01:00 (Migrated from github.com)
Copy link

By the way, HypItem was mostly written when I was still using FlowBox instead of GridView so without the possibility of reusing items. I plan to rewrite the whole thing paying attention to what properties might change between uses.

By the way, HypItem was mostly written when I was still using FlowBox instead of GridView so without the possibility of reusing items. I plan to rewrite the whole thing paying attention to what properties might change between uses.
rdbende (Migrated from github.com) reviewed 2023年12月18日 12:43:15 +01:00
rdbende (Migrated from github.com) commented 2023年12月18日 12:43:15 +01:00

I think it's just simpler and cleaner in cases like this, simply because of the semantics, e.g. "if something then do this else do that", and not "if something then do this and return, but otherwise there's more code further down". But that's it.

I think it's just simpler and cleaner in cases like this, simply because of the semantics, e.g. *"if something then do this else do that"*, and not *"if something then do this and return, but otherwise there's more code further down"*. But that's it.
rdbende (Migrated from github.com) reviewed 2023年12月18日 12:45:35 +01:00
rdbende (Migrated from github.com) commented 2023年12月18日 12:45:35 +01:00

Ah, right. Didn't notice there was a method for this :)

Ah, right. Didn't notice there was a method for this :)
kra-mo (Migrated from github.com) reviewed 2023年12月18日 12:48:59 +01:00
kra-mo (Migrated from github.com) commented 2023年12月18日 12:48:59 +01:00

I just like to avoid indentation as much as possible, I think it makes the code easier to read, so I prefer this syntax at places like this.

I just like to avoid indentation as much as possible, I think it makes the code easier to read, so I prefer this syntax at places like this.
rdbende (Migrated from github.com) reviewed 2023年12月18日 13:01:45 +01:00
rdbende (Migrated from github.com) commented 2023年12月18日 13:01:45 +01:00

Hmm, ok. That also makes sense.

Hmm, ok. That also makes sense.
Commenting is not possible because the repository is archived.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
kramo/hyperplane!6
Reference in a new issue
kramo/hyperplane
No description provided.
Delete branch "item-color-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?