• Joined on 2023年06月14日
klin commented on pull request Kbin/kbin-core#167 2023年07月06日 07:34:08 +02:00
Add support for collapsable comment threads/trees on click

I'll take a look at this once we know we're going to get the ball rolling on approving this, otherwise I'll just wait til when this is ready to be reviewed to fix all the conflicts altogether.....

klin pushed to no-avatar-improvement at klin/kbin-core 2023年06月21日 10:27:12 +02:00
b59ae618a5 Merge branch 'develop' into no-avatar-improvement
7314a40da3 Merge pull request 'Fix findboost query' (#411) from hotfix/boost_repo_typo into develop
23c25a58f3 Fix findboost query
110fca29e0 Merge pull request 'User second level cache' (#410) from doctrine_user_cache into develop
5b581cd392 User second level cache
Compare 16 commits »
klin commented on issue Kbin/kbin-core#353 2023年06月19日 00:52:42 +02:00
!ANNOUNCEMENT Pull request reviews

I'm going to try to help by triaging some of the low-hanging fruit in the Issues list. If I could have the ability to add labels once you trust me, I think that would be useful.

i also have a...

klin commented on issue Kbin/kbin-core#353 2023年06月18日 18:30:31 +02:00
!ANNOUNCEMENT Pull request reviews

hey thanks for all the hard work! hope you have a great weekend! :D

klin commented on pull request Kbin/kbin-core#214 2023年06月18日 01:26:49 +02:00
Implements #211: Add option to show instances next to users and magazines

adding some screenshots of this would probably help, but this seems good!

klin commented on pull request Kbin/kbin-core#167 2023年06月18日 00:09:17 +02:00
Add support for collapsable comment threads/trees on click

I like it.

One thing I'd like to see differently though is the hard coding of the [+] in the JS. Maybe use a new class or something and use ::after in the CSS to add a display in? That...

klin pushed to click-to-collapse-comment-tree at klin/kbin-core 2023年06月18日 00:08:42 +02:00
68f480f23a remove innerHTML setting and use ::after css selectors instead
klin created pull request Kbin/kbin-core#334 2023年06月17日 23:33:22 +02:00
Implements #321: Add default user avatar (instance logo), avatar component improvements
klin pushed to no-avatar-improvement at klin/kbin-core 2023年06月17日 23:22:00 +02:00
14b581acbb add default blank avatar (instance logo). reuse component across some hard coded places
klin created branch no-avatar-improvement in klin/kbin-core 2023年06月17日 23:22:00 +02:00
klin commented on issue Kbin/kbin-core#306 2023年06月17日 22:37:50 +02:00
Issue to discuss UI improvements across the board?

i feel like we should open issues or discuss here some of the existing kbinstyles, and look into actually implementing them!

klin commented on issue Kbin/kbin-core#321 2023年06月17日 22:36:53 +02:00
Thoughts on having empty user display pictures replaced with kbin logo?

i just took whatever kbin.social/logo.png was, so if an instance has a different logo it'd automagically use that! let me put up a quick PR for this

klin commented on issue Kbin/kbin-core#306 2023年06月17日 17:59:16 +02:00
Issue to discuss UI improvements across the board?

thoughts on default profile avatar image?

Kbin/kbin-core#321 (comment)

klin commented on issue Kbin/kbin-core#321 2023年06月17日 17:58:48 +02:00
Thoughts on having empty user display pictures replaced with kbin logo?

or maybe black and white so it doesn't stand out so much?

Screenshot 2023年06月17日 at 11.58.34 AM.png

klin opened issue Kbin/kbin-core#321 2023年06月17日 17:57:32 +02:00
Thoughts on having empty user display pictures replaced with kbin logo?
klin commented on issue Kbin/kbin-core#298 2023年06月17日 07:56:16 +02:00
[Enhancement] Reduce vertical spacing between comments

I opened a quick PR that does this! (Kbin/kbin-core#307)

Screenshots

Before Before

...

klin created pull request Kbin/kbin-core#307 2023年06月17日 07:53:58 +02:00
Reduce vertical spacing between comments
klin pushed to compacter-comments at klin/kbin-core 2023年06月17日 07:53:13 +02:00
8ac3ed68ca reduce vertical spacing, increase mobile nested comment margin
klin pushed to compacter-comments at klin/kbin-core 2023年06月17日 07:52:31 +02:00