9
13
Fork
You've already forked keyoxide-docs
23

Correct discord documentation #35

Open
tyy wants to merge 1 commit from tyy/keyoxide-docs:main into main
pull from: tyy/keyoxide-docs:main
merge into: keyoxide:main
keyoxide:main
keyoxide:new-claim-eveonline-143
keyoxide:add-guide
Member
Copy link

The docs currently indicate that when creating a discord proof someone may want to delete all channels. However, as indicated in keyxoide/doipjs#111, that does not work. This updates the language to clarify that at least one channel is necessary, but any other channels may be deleted.

The reason for needing one channel is that all invites are linked to a channel (this is the channel that first opens when someone uses an invite), and so deleting all channels will invalidate all existing invites, and makes the "create invite" button fail to function.

The docs currently indicate that when creating a discord proof someone may want to delete all channels. However, as indicated in keyxoide/doipjs#111, that does not work. This updates the language to clarify that at least one channel is necessary, but any other channels may be deleted. The reason for needing one channel is that all invites are linked to a channel (this is the channel that first opens when someone uses an invite), and so deleting all channels will invalidate all existing invites, and makes the "create invite" button fail to function.
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u main:tyy-main
git switch tyy-main

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff tyy-main
git switch tyy-main
git rebase main
git switch main
git merge --ff-only tyy-main
git switch tyy-main
git rebase main
git switch main
git merge --no-ff tyy-main
git switch main
git merge --squash tyy-main
git switch main
git merge --ff-only tyy-main
git switch main
git merge tyy-main
git push origin main
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Contribution welcome
Get started contributing here
Good first issue
Good if you are new to the project or to open source contributions
Impact
External
Affects the people using the project
Impact
Internal
Affects on the people working on the project
Priority
Critical
Work on right now
Priority
High
Work on at earliest convenience
Priority
Low
Work on in spare time
Priority
Medium
Work on regularly
Review
Duplicate
Already exists
Review
Off Topic
Does not fall within the scope of the repo/project
Status
Backlog
Is not being worked on yet
Status
Blocked
Is waiting on something or someone
Status
Completed
Is done
Status
In Progress
Is being worked on
Status
Investigating
Is waiting on research or questions
Status
Needs Decision
Is waiting on a decision by the devs/contributors
Status
Needs Info
Is waiting on additional information before it can be solved
Status
Needs Triage
Is new issue that needs reviewing
Status
Testing
Is being checked and verified
Status
Waiting For Review
Is waiting on reviewers to approve
Status
Won't Fix
Won't be fixed
Type
Bug
Related to something not working as intended
Type
CI
Related to continuous integration
Type
Documentation
Related to documentation
Type
Enhancement
Related to a new feature or an improved one
Type
New Claim
Related to a new identity claim/proof
Type
Security
Related to security
Type
Tests
Related to code tests
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
keyoxide/keyoxide-docs!35
Reference in a new issue
keyoxide/keyoxide-docs
No description provided.
Delete branch "tyy/keyoxide-docs:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?