keyoxide/doipjs

Fork 28

Code Issues 56 Pull requests 24 Projects Releases 89 Activity

Enable linting of examples & tests #79

Open

vladimyr wants to merge 4 commits from vladimyr/doipjs:lint-everything into dev

pull from: vladimyr/doipjs:lint-everything

merge into: keyoxide:dev

keyoxide:main

keyoxide:dev

keyoxide:fix-irc-fetcher

keyoxide:new-claim-eveonline-143

keyoxide:prepare-new-release

keyoxide:fix-jsdoc-types

keyoxide:yarn-to-npm

keyoxide:support-openpgp-aspe-claims

keyoxide:support-html-alias

keyoxide:improve-activitypub-support

keyoxide:v1-restructure

keyoxide:into-es-module

keyoxide:support-aspe

keyoxide:fix-js-lsp-issues

keyoxide:improve-linting

keyoxide:add-markers

keyoxide:support-opencollective-claim

keyoxide:support-entity-decoding

keyoxide:use-rome-tools

keyoxide:support-cloudflare-buster

keyoxide:support-fediverse-posts

keyoxide:matrix-room-verification

Conversation 7 Commits 4 Files changed 18 +109 -92

vladimyr commented

2024年01月31日 03:46:09 +01:00

Member

Copy link

Altering ESLint config so everything besides dist and docs is linted while ensuring correct treatment of Mocha tests.

Altering ESLint config so everything besides `dist` and `docs` is linted while ensuring correct treatment of Mocha tests.

vladimyr added the

Type

Enhancement

label

2024年01月31日 04:03:19 +01:00

tyy added the

labels

2024年01月31日 08:04:54 +01:00

yarmo commented

2024年01月31日 09:58:10 +01:00

Owner

Copy link

That's neat, makes a lot of sense to lint examples and tests too. I don't suppose it's possible to lint the JSDoc @example tags as well 👀 from a quick internet search, perhaps not

It's a pretty straightforward PR. Have you run yarn run build to check whether the builds still work? Hmm I suppose the CI should do that as well

That's neat, makes a lot of sense to lint examples and tests too. I don't suppose it's possible to lint the JSDoc `@example` tags as well 👀 from a quick internet search, perhaps not It's a pretty straightforward PR. Have you run `yarn run build` to check whether the builds still work? Hmm I suppose the CI should do that as well

Ryuno-Ki approved these changes

2024年02月01日 22:48:09 +01:00

Ryuno-Ki left a comment

Copy link

Splendid!

❤️ 1

examples/test-service-provider.js Outdated

@ -6,1 +4,3 @@

console.log(sp);

 // const sp = doip.ServiceProviderDefinitions.data['activitypub'].processURI('https://fosstodon.org/@yarmo')

const sp = doip.ServiceProviderDefinitions.data.discourse.processURI('https://domain.org/u/alice')

console.log(sp)

Ryuno-Ki commented

2024年02月01日 22:46:37 +01:00

Owner

Copy link

That could be another rule to add in a future PR: no-console.

vladimyr commented

2024年02月02日 13:34:06 +01:00

Author

Member

Copy link

Indeed 👍

Ryuno-Ki commented

2024年02月01日 22:48:48 +01:00

Owner

Copy link

Mocha has the best reporter ever for local development 😻

Mocha has the [best reporter ever for local development](https://mochajs.org/#nyan) 😻

vladimyr commented

2024年02月02日 13:33:19 +01:00

Author

Member

Copy link

It's a pretty straightforward PR. Have you run yarn run build to check whether the builds still work? Hmm I suppose the CI should do that as well

Good idea, I'll diff old and new build output and paste results here.

> It's a pretty straightforward PR. Have you run `yarn run build` to check whether the builds still work? Hmm I suppose the CI should do that as well Good idea, I'll diff _old_ and _new_ build output and paste results here.

vladimyr force-pushed lint-everything from a35b86c362

All checks were successful

ci/woodpecker/pr/test Pipeline was successful

Details

to cb1fd4a3b6

All checks were successful

ci/woodpecker/pr/test Pipeline was successful

Details

2024年02月02日 13:56:57 +01:00

Compare

vladimyr changed title from ~~(削除) Enable linting of examples & tests (削除ここまで)~~ to WIP: Enable linting of examples & tests

2024年02月02日 13:57:52 +01:00

vladimyr commented

2024年02月02日 21:34:18 +01:00

Author

Member

Copy link

So here is what I did. First I built the library on the current dev branch and renamed dist to dist@dev. Then I switched to the branch behind this PR (lint-everything), created a new build, and compared the two:

$ git branch --show-current && diff -rs dist@dev dist
lint-everything
Files dist@dev/doip.core.js and dist/doip.core.js are identical
Files dist@dev/doip.core.min.js and dist/doip.core.min.js are identical
Files dist@dev/doip.fetchers.js and dist/doip.fetchers.js are identical
Files dist@dev/doip.fetchers.minimal.js and dist/doip.fetchers.minimal.js are identical
Files dist@dev/doip.fetchers.minimal.min.js and dist/doip.fetchers.minimal.min.js are identical
Files dist@dev/doip.fetchers.min.js and dist/doip.fetchers.min.js are identical

As you can see there are no changes in the build output so this should be ready and safe to merge.

So here is what I did. First I built the library on the current `dev` branch and renamed `dist` to `dist@dev`. Then I switched to the branch behind this PR (lint-everything), created a new build, and compared the two: ``` $ git branch --show-current && diff -rs dist@dev dist lint-everything Files dist@dev/doip.core.js and dist/doip.core.js are identical Files dist@dev/doip.core.min.js and dist/doip.core.min.js are identical Files dist@dev/doip.fetchers.js and dist/doip.fetchers.js are identical Files dist@dev/doip.fetchers.minimal.js and dist/doip.fetchers.minimal.js are identical Files dist@dev/doip.fetchers.minimal.min.js and dist/doip.fetchers.minimal.min.js are identical Files dist@dev/doip.fetchers.min.js and dist/doip.fetchers.min.js are identical ``` As you can see there are no changes in the build output so this should be ready and safe to merge.

vladimyr changed title from ~~(削除) WIP: Enable linting of examples & tests (削除ここまで)~~ to Enable linting of examples & tests

2024年02月02日 21:34:51 +01:00

Ryuno-Ki approved these changes

2024年02月05日 10:39:03 +01:00

Ryuno-Ki added

and removed

labels

2024年02月05日 10:39:36 +01:00