10
45
Fork
You've already forked doipjs
28

Update signature profile example #74

Open
vladimyr wants to merge 1 commit from vladimyr/doipjs:fix-sig-profile-example into dev
pull from: vladimyr/doipjs:fix-sig-profile-example
merge into: keyoxide:dev
keyoxide:main
keyoxide:dev
keyoxide:fix-irc-fetcher
keyoxide:new-claim-eveonline-143
keyoxide:prepare-new-release
keyoxide:fix-jsdoc-types
keyoxide:yarn-to-npm
keyoxide:support-openpgp-aspe-claims
keyoxide:support-html-alias
keyoxide:improve-activitypub-support
keyoxide:v1-restructure
keyoxide:into-es-module
keyoxide:support-aspe
keyoxide:fix-js-lsp-issues
keyoxide:improve-linting
keyoxide:add-markers
keyoxide:support-opencollective-claim
keyoxide:support-entity-decoding
keyoxide:use-rome-tools
keyoxide:support-cloudflare-buster
keyoxide:support-fediverse-posts
keyoxide:matrix-room-verification

The current version of the signature profile example is broken due to recent API changes.

The current version of the signature profile example is broken due to recent API changes.
vladimyr force-pushed fix-sig-profile-example from 48efa21013
All checks were successful
ci/woodpecker/pr/test Pipeline was successful
to 4f67247b09
All checks were successful
ci/woodpecker/pr/test Pipeline was successful
2024年01月30日 04:05:08 +01:00 Compare
Ryuno-Ki left a comment
Copy link

Sounds reasonable.

Sounds reasonable.
@ -29,3 +29,3 @@
// Log the claims of the first persona
console.log(profile.users[0].claims)
console.log(profile.personas[0].claims)
Owner
Copy link

Generally speaking, I made the experience, that plain logging makes it hard to find the source of a log. If you want, I can file another issue to explain it in more depth.

Generally speaking, I made the experience, that plain logging makes it hard to find the source of a log. If you want, I can file another issue to explain it in more depth.
Author
Member
Copy link

Oh, definitely. I also tend to use either object form or prefix my logs with labels. We can do it for all examples as separate PR?

Oh, definitely. I also tend to use either object form or prefix my logs with labels. We can do it for all examples as separate PR?
Owner
Copy link

I've filled #83 with this.

I've filled https://codeberg.org/keyoxide/doipjs/issues/83 with this.
Ryuno-Ki marked this conversation as resolved
vladimyr changed title from (削除) Update signature profile example (削除ここまで) to WIP: Update signature profile example 2024年02月02日 13:44:15 +01:00
Author
Member
Copy link

Accidentally hit update branch by merge instead of rebase, will fix this mess later on.

Accidentally hit update branch by merge instead of rebase, will fix this mess later on.
vladimyr force-pushed fix-sig-profile-example from 862cc4c019
All checks were successful
ci/woodpecker/pr/test Pipeline was successful
to 37e8cbbb23
All checks were successful
ci/woodpecker/pr/test Pipeline was successful
2024年02月02日 21:02:44 +01:00 Compare
vladimyr changed title from (削除) WIP: Update signature profile example (削除ここまで) to Update signature profile example 2024年02月02日 21:02:56 +01:00
All checks were successful
ci/woodpecker/pr/test Pipeline was successful
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix-sig-profile-example:vladimyr-fix-sig-profile-example
git switch vladimyr-fix-sig-profile-example
Sign in to join this conversation.
No reviewers
Labels
Clear labels
bug
Something is not working

Archived

enhancement
New feature

Archived

Contribution welcome
Get started contributing here
Good first issue
Good if you are new to the project or to open source contributions
Impact
External
 Affects the people using the project
Impact
Internal
 Affects on the people working on the project
Priority
Critical
 Work on right now
Priority
High
 Work on at earliest convenience
Priority
Low
 Work on in spare time
Priority
Medium
 Work on regularly
Review
Duplicate
 Already exists
Review
Off Topic
 Does not fall within the scope of the repo/project
Status
Backlog
 Is not being worked on yet
Status
Blocked
 Is waiting on something or someone
Status
Completed
 Is done
Status
In Progress
 Is being worked on
Status
Investigating
 Is waiting on research or questions
Status
Needs Decision
 Is waiting on a decision by the devs/contributors
Status
Needs Info
 Is waiting on additional information before it can be solved
Status
Needs Triage
 Is new issue that needs reviewing
Status
Testing
 Is being checked and verified
Status
Waiting For Review
 Is waiting on reviewers to approve
Status
Won't Fix
 Won't be fixed
Type
Bug
 Related to something not working as intended
Type
CI
 Related to continuous integration
Type
Documentation
 Related to documentation
Type
Enhancement
 Related to a new feature or an improved one
Type
New Claim
 Related to a new identity claim/proof
Type
Security
 Related to security
Type
Tests
 Related to code tests
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
keyoxide/doipjs!74
Reference in a new issue
keyoxide/doipjs
No description provided.
Delete branch "vladimyr/doipjs:fix-sig-profile-example"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?